Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with other BG packages #127

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Align with other BG packages #127

merged 6 commits into from
Jul 29, 2022

Conversation

adamltyson
Copy link
Member

A bit of a catch all PR, I've made some changes to reduce the maintenance burden by making this package more like the other BG packages. Including:

  • Updating tox configuration
  • Moving the requirements to the setup file. Not sure if this is good or bad, but it's what we have with every other package, and having the separate files was stopping tox from working for some reason.
  • Updated links in setup.py
  • Added & updated badges in the readme
  • Moved from coveralls to codecov to report coverage
  • Updated supported Python versions
  • Removed changelog. Although we should have one, we haven't updated this for two years, so I think it's a net negative currently.

There are no changes to the code or the packaging.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@cc98014). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #127   +/-   ##
=========================================
  Coverage          ?   85.26%           
=========================================
  Files             ?       11           
  Lines             ?      536           
  Branches          ?        0           
=========================================
  Hits              ?      457           
  Misses            ?       79           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc98014...7d63e65. Read the comment docs.

Copy link
Member

@vigji vigji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a great fan of requirements embedded in the setup.py but for no strong reason, I am happy with consistency!

Is there a specific reason not to support v3.7?

@adamltyson
Copy link
Member Author

I am not a great fan of requirements embedded in the setup.py but for no strong reason, I am happy with consistency!

That was my logic, there are a lot of repos now, and the more similar they are, the easier they are to maintain.

Is there a specific reason not to support v3.7?

To follow NEP29. Since numpy 1.22, only Python >= 3.8 are supported.

@yoda-vid
Copy link
Contributor

To follow NEP29. Since numpy 1.22, only Python >= 3.8 are supported.

Thanks for pointing out this link! Didn't know about this deprecation schedule, good to know.

Copy link
Member

@vigji vigji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok than, thanks for pointing it out, I was also not aware of it!
Good to go for me then.

@adamltyson adamltyson merged commit 179e267 into master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants