-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with other BG packages #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage ? 85.26%
=========================================
Files ? 11
Lines ? 536
Branches ? 0
=========================================
Hits ? 457
Misses ? 79
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a great fan of requirements embedded in the setup.py but for no strong reason, I am happy with consistency!
Is there a specific reason not to support v3.7
?
That was my logic, there are a lot of repos now, and the more similar they are, the easier they are to maintain.
To follow NEP29. Since numpy 1.22, only Python >= 3.8 are supported. |
Thanks for pointing out this link! Didn't know about this deprecation schedule, good to know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok than, thanks for pointing it out, I was also not aware of it!
Good to go for me then.
A bit of a catch all PR, I've made some changes to reduce the maintenance burden by making this package more like the other BG packages. Including:
There are no changes to the code or the packaging.