-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added a few small comments.
Should all be fixed - I took the liberty as marking everything as resolved above as they were pretty clear cut changes. |
Codecov ReportBase: 85.26% // Head: 85.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 85.26% 85.26%
=======================================
Files 11 11
Lines 536 536
=======================================
Hits 457 457
Misses 79 79 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This updates the packaging to use
pyproject.toml
, following the template at https://github.com/SainsburyWellcomeCentre/python-cookiecutter. This is the first time I've (manually) applied that template to a package, so would appreciate a careful check that I've done everything right.