Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml #139

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Switch to pyproject.toml #139

merged 6 commits into from
Feb 24, 2023

Conversation

dstansby
Copy link
Member

This updates the packaging to use pyproject.toml, following the template at https://github.com/SainsburyWellcomeCentre/python-cookiecutter. This is the first time I've (manually) applied that template to a package, so would appreciate a careful check that I've done everything right.

@dstansby dstansby marked this pull request as ready for review February 21, 2023 16:50
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added a few small comments.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@dstansby
Copy link
Member Author

Should all be fixed - I took the liberty as marking everything as resolved above as they were pretty clear cut changes.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 85.26% // Head: 85.26% // No change to project coverage 👍

Coverage data is based on head (28e09d3) compared to base (080b577).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          11       11           
  Lines         536      536           
=======================================
  Hits          457      457           
  Misses         79       79           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamltyson adamltyson merged commit 4aaadba into brainglobe:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants