New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved atlas_gen to separate package #29
Conversation
Final test structure:
Tests are significantly faster now, although Windows still take some more time to setup. Maybe we could temporarily disable that together with macOS? I left all the code in the travis folder though, so put them back in the future will be straightforward. I also added a separate requirements.txt file for easy deps parsing. I think this should be mergeable now! @adamltyson ? |
I won't have time to review this properly until tomorrow, but it looks ok. I'm keen to keep as much testing as we can though, because I've come across python version/OS interactions in the past, when wheels are only built for specific versions etc.
I think we should absolutely keep the Windows test, and I would like to bring the macOS test back if we can. Ideally we would also test every combination, but as this takes a long time, maybe we can keep it for tagged commits (i.e. to prevent deployment if there is an issue)? Sorry to be a pain, but I think the tests taking a bit longer isn't much of an issue if we make sure everything passes locally (and maybe be selective with the commits we push?). I'm also wary that I will be maintaining quite a lot of software that will likely depend on this package, so I'm keen to test as much as is practical. |
Ok, I added back the macOS test. True that testing locally should take care of most problems. Still, maybe all the matrix is an overkill for all commits. If you know a way of trigger the job will all OSs and all versions only on marked commits that would be great! |
I will marge for now as I don't see potential issues, but let me know if something's not ok. I am happy to reintroduce the grid testing if it can restricted to tags in the future! |
Cool, I've added this functionality in #30. |
In this PR: