Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #143

Closed
goanpeca opened this issue Nov 7, 2023 · 0 comments · Fixed by #144
Closed

Update dependencies #143

goanpeca opened this issue Nov 7, 2023 · 0 comments · Fixed by #144
Assignees
@willGraham01
Labels
bug Something isn't working

Comments

@goanpeca
Copy link

goanpeca commented Nov 7, 2023 •
edited

Hi team, while working on conda-forge/brainreg-segment-feedstock#7

We noticed that the following packages are directly imported in source but not listed as requirements.

  • bg-atlasapi
  • qtpy
  • scipy
  • tifffile

Also, the following packages seem to be required as dependencies, but are not used in the source code

  • brainglobe-napari-io
  • dask-core
  • pytables
  • napari-plugin-engine

Is this correct? Could this be updated for the next release ?

Cheers 🚀 !
@goanpeca goanpeca added the bug Something isn't working label Nov 7, 2023
@goanpeca goanpeca mentioned this issue Nov 7, 2023
Merged
3 tasks
@willGraham01 willGraham01 self-assigned this Nov 7, 2023
willGraham01 added a commit that referenced this issue Nov 7, 2023
@willGraham01
Update dependencies in line with #143
a1aacb1
@willGraham01 willGraham01 mentioned this issue Nov 7, 2023
Merged
willGraham01 added a commit that referenced this issue Nov 7, 2023
@willGraham01
Revert "Update dependencies in line with #143"
aa36fda 
This reverts commit a1aacb1.
willGraham01 added a commit that referenced this issue Nov 7, 2023
@willGraham01
Update dependencies in line with #143
813ca5c
willGraham01 added a commit that referenced this issue Nov 7, 2023
@willGraham01
Revert "Update dependencies in line with #143"
d5a7856 
This reverts commit a1aacb1.
adamltyson pushed a commit that referenced this issue Nov 7, 2023
@willGraham01
Update dependencies in line with #143 (#144)
ed16aba 
* Update dependencies in line with #143

* Revert "Update dependencies in line with #143"

This reverts commit a1aacb1.

* First, add missing explicit dependencies

* Remove napari plugin engine, not required

* Remove dask

* Depend on pandas[hdf5] to fetch tables

* Remove npe2, since we can run without it
@willGraham01 willGraham01 mentioned this issue Nov 7, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willGraham01 willGraham01

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependencies in line with #143 brainglobe/brainglobe-segmentation
2 participants
@goanpeca @willGraham01