Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if data segmented in a different coordinate space #107

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Jun 22, 2023

Closes #103

This adds a warning to the user, and also adds a specific check for region images that will prevent analysis from being run if the image sizes don't match. Ideally we'd have something like this for 1D tracks, but not entirely sure how to this (they don't exist "in" an image that can be checked). The analysis will usually run, but errors may occur. I think the warning (and documentation) should be ok.

@adamltyson adamltyson marked this pull request as draft June 22, 2023 13:01
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/brainreg-segment/107
Updated: 2023-06-26T14:52:51.867303

@adamltyson adamltyson marked this pull request as ready for review June 23, 2023 09:56
@adamltyson adamltyson requested a review from a team June 23, 2023 09:56
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Found a small typo that existed before.

tests/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
@adamltyson adamltyson merged commit 398772a into main Jun 26, 2023
6 checks passed
@adamltyson adamltyson deleted the coord-space branch June 26, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] add region from selected layer _ for atlas space
2 participants