Make test assertions approximate #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some analysis are not exactly the same across OSs/architectures, causing tests to fail. Very small numerical differences can cause (seemingly) large differences in the results (such as assigning a feature to a brain region 1 voxel away).
This PR makes the assertions more approximate to check that while the exact values are not the same, the analysis is still being performed correctly. This isn't ideal, but failing tests mask new failures during development.
Also updates the gitignore file to stop
.DS_Storefiles making their way in.Closes #117