-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new button to import an existing layers from other plugins #74
Conversation
Converted to draft as I'd like to get some feedback on the tool from a user POV, and also add similar functionality for tracks. |
Also need to add tests |
Preview page for your plugin is ready here: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 59.86% 60.48% +0.61%
==========================================
Files 20 20
Lines 887 916 +29
==========================================
+ Hits 531 554 +23
- Misses 356 362 +6
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Moved the test changes from this branch into #77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three major comments:
- See inline comments, I think worth checking the layer type and erroring when adding the existing layers in the functions that do the adding.
- I can't get any of the info boxes to pop up, even when trying to add a layer that is the wrong type. Not sure what the best way to debug this is though...
- This could really do with some user facing docs, but I guess we don't have anywhere to put them right now? Perhaps a simple markdown file with a short "how to import existing layers" section could be started, and then when a proper doc structure is added to the repo it can be migrated there.
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: David Stansby <dstansby@gmail.com>
Thanks @dstansby I've addressed these issues. I'll document this feature in the new docs site before the new version is released. @SaraMederos is also kindly developing a tutorial from the researchers point of view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked this works as intended, but I have smoke checked it and the info boxes seem to be working now 👍
Description
There's now a good number of segmentation plugins in napari. Following a conversation with @SaraMederos, it seems like a good idea to be able to "import" these results into
brainreg-segment
so that they can be analysed in the context of the atlas.What is this PR
What does this PR do?
Adds a
Add region from selected layer
to the region segmentation panel that will add the selected layer (e.g. from a segmentation plugin) to the list of layers to be analysed.Adds a
Add track from selected layer
to the track segmentation panel that will add the selected layer (e.g. from another plugin) to the list of layers to be analysed.References
Closes #73
How has this PR been tested?
No automated tests yet, as all the tests are broken in some way.
Is this a breaking change?
No
Does this PR require an update to the documentation?
Yes, it will, not added yet though.
Checklist: