Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache atlases in CI for brainmapper tests #101

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Apr 30, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To try and speed up the CI checks, we want to cache the download of atlases for the brainmapper tests.

What does this PR do?
Adds a step in the tests job to cache the .brainglobe folder.

References

#65

How has this PR been tested?

Checks in this PR should pass.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • [ n/a] The code has been tested locally
  • [ n/a] Tests have been added to cover all new functionality (unit & integration)
  • [ n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig changed the title Cache atlases in CI before brainmapper tests Cache atlases in CI for brainmapper tests Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (b5f62ef) to head (572be3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   79.38%   84.45%   +5.06%     
==========================================
  Files          18       17       -1     
  Lines         917      862      -55     
==========================================
  Hits          728      728              
+ Misses        189      134      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review April 30, 2024 14:14
@sfmig sfmig requested review from a team and removed request for a team April 30, 2024 14:14
@sfmig sfmig assigned sfmig and unassigned sfmig Apr 30, 2024
@sfmig sfmig marked this pull request as draft April 30, 2024 16:14
@sfmig sfmig marked this pull request as ready for review April 30, 2024 17:33
@sfmig sfmig requested a review from adamltyson April 30, 2024 17:34
@adamltyson adamltyson merged commit 78b6a1c into main May 1, 2024
11 checks passed
@adamltyson adamltyson deleted the smg/cache-atlases branch May 1, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants