Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to TensorFlow related cellfinder functions #112

Merged
merged 1 commit into from
May 28, 2024

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented May 23, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Cellfinder is now using PyTorch so functions related to suppressing TensorFlow error messages no longer exist.

What does this PR do?
Removes any comments and function calls relating to suppressing TensorFlow error messages.

References

Waiting on brainglobe/cellfinder#418 to be merged

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (3cedfbc) to head (b4b7146).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   85.68%   85.64%   -0.04%     
==========================================
  Files          16       16              
  Lines         838      836       -2     
==========================================
- Hits          718      716       -2     
  Misses        120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson merged commit 2136585 into main May 28, 2024
12 checks passed
@adamltyson adamltyson deleted the remove-suppress-tensorflow-functions branch May 28, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants