Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard dependency on brainglobe-meta package #72

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Jan 5, 2024

See brainglobe/BrainGlobe#33 | This should be the final task in the list, so it actually closes brainglobe/BrainGlobe#33 😱

As per the version 1 release plan, this repository should depend on the meta-package rather than the individual tooling packages themselves.

As such, have added brainglobe>=1.0.0 to the top of the dependency list.
Have left in the explicit brainreg>=1.0.0 and cellfinder>=1.0.0 dependencies, even though these (or the most recent versions) should be fetched by the meta-package anyway.
This just ensures that the minimum version of the meta-package that will be fetched must be one that adheres to our BrainGlobe version 1 update: IE fetching the new cellfinder package and brainreg plugins.

Depends on:

CI will fail until all of the above are met.

@adamltyson
Copy link
Member

Have left in the explicit brainreg>=1.0.0 and cellfinder>=1.0.0 dependencies, even though these (or the most recent versions) should be fetched by the meta-package anyway.

Shall we remove these? it seems weird to have some specific packages pinned and not others. We have to keep the metapackage dependencies up to date anyway, so we may as well fully rely on that.

@willGraham01
Copy link
Collaborator Author

Shall we remove these? it seems weird to have some specific packages pinned and not others. We have to keep the metapackage dependencies up to date anyway, so we may as well fully rely on that.

Up to you and how much faith you have in the metapackage 😅 I ran this by @alessandrofelder briefly last week and we came to the same conclusion - let's just depend on the metapackage and be vigilant, as it's better to test from a user-style install than a developer one.

Although @sfmig might want to preserve the explicit dependencies in her ASV benchmark dependencies? Theoretically though the metapackage will handle that too...

@alessandrofelder
Copy link
Member

Although @sfmig might want to preserve the explicit dependencies in her ASV benchmark dependencies?

Should the benchmarks at some point mainly run on the development versions of the tools, to warn developers about problems before we release?

@willGraham01
Copy link
Collaborator Author

Should the benchmarks at some point mainly run on the development versions of the tools, to warn developers about problems before we release?

Ideally yeah, though there's no nice way to get pip (within the ASV environment) to install development versions of our packages as it heads over to standard PyPI channels. I have a couple of ideas for a hack though, depending on how adventurous we're feeling.

@alessandrofelder
Copy link
Member

Ideally yeah,

Cool, let's make that a separate issue to this :)

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2ba47e) 81.43% compared to head (3b664b0) 81.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          29       29           
  Lines        1573     1573           
=======================================
  Hits         1281     1281           
  Misses        292      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member

Merging this so we can release.

@adamltyson adamltyson merged commit 0c242b1 into main Jan 9, 2024
10 checks passed
@adamltyson adamltyson deleted the bg-version-1-release branch January 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] BrainGlobe v1 Plan
3 participants