Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and refactor #79

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Remove unused code and refactor #79

merged 3 commits into from
Jan 16, 2024

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Jan 15, 2024

Follows on from #74 & #76. This PR:

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2b19243) 85.08% compared to head (845b25d) 79.43%.

Files Patch % Lines
tests/brainmapper/test_unit/test_prep.py 52.63% 18 Missing ⚠️
brainglobe_workflows/brainmapper/analyse.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   85.08%   79.43%   -5.65%     
==========================================
  Files          26       18       -8     
  Lines        1448      924     -524     
==========================================
- Hits         1232      734     -498     
+ Misses        216      190      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson marked this pull request as ready for review January 15, 2024 18:17
@adamltyson adamltyson requested a review from a team January 15, 2024 18:18
Copy link
Contributor

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - seems much lighter now ✨

@sfmig sfmig merged commit cd14205 into main Jan 16, 2024
8 of 10 checks passed
@alessandrofelder alessandrofelder deleted the refactor branch February 22, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants