Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor installation/test running fixing #254

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Oct 26, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

  • I managed to remove a pyside2 dev dependency in the mega-fix branch, which was needed
  • we should stop supporting py3.8 and test on py3.11 to follow NEP 29
  • CI currently fails fast, so it's hard to get an overview of how tests are faring across OSs and Python version

What does this PR do?

  • adds pyside2 to dependencies
  • drops support for Python 3.8.
  • ensures all CI workflows are run even if one fails by setting strategy.fail-fast = false

References

Closes #252
Closes #256

How has this PR been tested?

Tests fail due to other reasons that lack of Qt back in CI run

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Not really, but see #253 for docs changes/improvements needed as part of megafix

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder changed the title fix lack of qtbindings in tox minor installation/test running fixing Oct 26, 2023
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@alessandrofelder alessandrofelder marked this pull request as ready for review October 27, 2023 08:59
@alessandrofelder alessandrofelder merged commit 3fd3359 into mega-fix Oct 27, 2023
7 of 17 checks passed
@alessandrofelder alessandrofelder deleted the fix-qt-bindings branch October 27, 2023 09:00
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants