Mega fix of brainrender #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
additionally this required mamba install pytables mamba install pyside2 on Mac M2 because pip couldn't easily figure those out. pyqt5 doesn't work as qt binding.
except streamlines, ruler, neurons some vedo API updates use pooch and new URL for zebrafish gene expression data additionally depend on imio
Closed
minor installation/test running fixing
pass DISPLAY env var to tox
This reverts commit f0a0306. Commit should have landed in `fix-video-test` branch!
* Added to changes to conform to vedo 2023.5.0+dev26a * Further compatibility updates * Changed function name in bm_cells from camel case to snake case * Fixed colormap related issue * Cleaned up return from volume.py::_from_numpy() * Fixed failing volume test by removing mode=2 for now
Fix video test
…ebra fish atlas marked as slow and local
…scene.py::test_screenshot
…r/resources, importlib.resources now used to fetch data
All examples rendering correctly with vedo 2023.5.0
* Note about slow tests in contributing paragraph * fix link to dev docs
This reverts commit 7796454.
7 tasks
adamltyson
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
This is excellent, thank you @alessandrofelder & @IgorTatarnikov!!
There are a few tiny things I've noticed, but I've raised issues (#288, #289, #290)so as to not delay this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Brainrender is not currently easy to install on all OSs and with recent Python versions, and was therefore declared temporarily unsupported.
What does this PR do?
Collects changes from lots of smaller PRs that are connected with the overall goal of making brainrender functional and installable with Python 3.9, 3.10, 3.11 and newest (or at least recent)
vedo(and newest other dependencies), so we can remove the current warning.This includes
vedo 2023.5.0/fixing rendering issues:brainrenderacross OSs with NEP 29 Python versions, and get tests to pass:test_export_htmland run it on CI #275brainrenderbrainglobe.github.io#111References
See issues closed in PRs above, and the milestone for this project.
How has this PR been tested?
Is this a breaking change?
Yes, in that we now support Python 3.9, 3.10 and 3.11 instead of Python <=3.8
Does this PR require an update to the documentation?
See "tidying up/documenting this changes" bullet points above.
Checklist: