Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass DISPLAY env var to tox #260

Merged
merged 1 commit into from
Oct 30, 2023
Merged

pass DISPLAY env var to tox #260

merged 1 commit into from
Oct 30, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Oct 27, 2023 •
edited

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently ubuntu test running crashes on CI

What does this PR do?

Sets up tox so it passes the DISPLAY env var from the host env to the tox env.

References

Closes #257

How has this PR been tested?

On Ubuntu, tox and gh act -j test now don't fail with a Fatal error locally or on CI, but rather fail as documented in #255

Is this a breaking change?

Nope.

Does this PR require an update to the documentation?

Nope.

Checklist:

  • The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review October 30, 2023 09:46
@alessandrofelder
Copy link
Member Author

igor verbally approves :)

IgorTatarnikov
IgorTatarnikov approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alessandrofelder alessandrofelder merged commit 3cf712a into mega-fix Oct 30, 2023
7 of 17 checks passed
@alessandrofelder alessandrofelder deleted the fix-ubuntu-tests branch October 30, 2023 10:12
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorTatarnikov IgorTatarnikov IgorTatarnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessandrofelder @IgorTatarnikov