Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install HDF5 for mac CI #265

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Install HDF5 for mac CI #265

merged 4 commits into from
Oct 30, 2023

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Installation of brainrender fails on MacOS.

What does this PR do?

Adds a step to the Mac CI that brew installs HDF5.

References

temporary fix for #259

How has this PR been tested?

Looking at CI output.

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Yes - we will document any new things that users need to do to install on Mac (If we can't avoid this).

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Oct 30, 2023
@alessandrofelder alessandrofelder changed the title try to install pyside2 via conda Install HDF5 for mac CI Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f638888) 67.86% compared to head (218c0ce) 67.86%.
Report is 1 commits behind head on mega-fix.

Additional details and impacted files
@@            Coverage Diff            @@
##           mega-fix     #265   +/-   ##
=========================================
  Coverage     67.86%   67.86%           
=========================================
  Files            26       26           
  Lines          1195     1195           
=========================================
  Hits            811      811           
  Misses          384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IgorTatarnikov IgorTatarnikov merged commit 8866e3a into mega-fix Oct 30, 2023
17 of 19 checks passed
@IgorTatarnikov IgorTatarnikov deleted the fix-mac-install branch October 30, 2023 13:32
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants