Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pyvista action for headless display in tox #273

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Tests fail weirdly with a display-related thing on Windows CI.

What does this PR do?

Brings the CI set-up of the headless display in line with napari and our napari plugins, ie uses a pyvista GitHub action to set up the headless display.

References

Closes #270

How has this PR been tested?

CI tests now all pass 🎉

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [NA] The code has been tested locally
  • [NA] Tests have been added to cover all new functionality (unit & integration)
  • [NA] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

this might fix VTK failures in windows
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a24de2) 67.86% compared to head (d40ab28) 67.94%.
Report is 3 commits behind head on mega-fix.

Additional details and impacted files
@@             Coverage Diff              @@
##           mega-fix     #273      +/-   ##
============================================
+ Coverage     67.86%   67.94%   +0.08%     
============================================
  Files            26       26              
  Lines          1195     1195              
============================================
+ Hits            811      812       +1     
+ Misses          384      383       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder self-assigned this Nov 15, 2023
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! All tests finally passing on CI 🎉

@IgorTatarnikov IgorTatarnikov merged commit 49817bd into mega-fix Nov 15, 2023
21 checks passed
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants