Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video test #276

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix video test #276

merged 1 commit into from
Nov 16, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 15, 2023

⚠️ Depends on #277 being merged first

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The local video tests fail because we don't install, or document anywhere explicit, (AFAICT) that ffmpeg is needed (the command line tool).

What does this PR do?
Makes the video tests not local, and sets up ffmpeg on CI.

References

People have struggled with this before: #202

How has this PR been tested?

This PR adds extra tests (previously only run locally) to the CI

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02b7565) 72.44% compared to head (f5a2de0) 81.15%.

Additional details and impacted files
@@             Coverage Diff              @@
##           mega-fix     #276      +/-   ##
============================================
+ Coverage     72.44%   81.15%   +8.71%     
============================================
  Files            26       26              
  Lines          1194     1194              
============================================
+ Hits            865      969     +104     
+ Misses          329      225     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@alessandrofelder
Copy link
Member Author

I'll try to rebase and then merge

@alessandrofelder alessandrofelder merged commit e6df766 into mega-fix Nov 16, 2023
19 checks passed
@alessandrofelder alessandrofelder deleted the fix-video-test branch November 16, 2023 14:32
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants