Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch PySide2 for PyQt5 #287

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Switch PySide2 for PyQt5 #287

merged 2 commits into from
Nov 30, 2023

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Description

Switched out PySide2 for PyQt5 in the dev dependencies. This allows CI to run using windows python 3.11.

What is this PR

  • Other

Why is this PR needed?
There is no versions of PySide2 that's compatible with python 3.11 and Windows.

What does this PR do?
Changed PySide2 to PyQt5

References

Closes #258

How has this PR been tested?

Tested locally and on CI

Is this a breaking change?

No

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5af51c) 86.39% compared to head (942d603) 86.39%.
Report is 11 commits behind head on mega-fix.

Additional details and impacted files
@@            Coverage Diff            @@
##           mega-fix     #287   +/-   ##
=========================================
  Coverage     86.39%   86.39%           
=========================================
  Files            26       26           
  Lines          1205     1205           
=========================================
  Hits           1041     1041           
  Misses          164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov changed the title Windows CI now runs on python 3.11, fetch pyside2 from conda-forge Switch PySide2 for PyQt5 Nov 30, 2023
@alessandrofelder alessandrofelder merged commit 3143d22 into mega-fix Nov 30, 2023
15 of 17 checks passed
@alessandrofelder alessandrofelder deleted the change-pyside2-pyqt5 branch November 30, 2023 17:51
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants