various (small) improvements #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid importing the full vtk namespace (speed) rename old 'clippingRange' -> 'clipping_range' rename old 'focalPoint' -> 'focal_point' - render.py remove import "matplotlib.pyplot as plt", this looks like a genuine bug and correct close() method avoid setting size='full' as this is poorly dealt with in vtk - add "actor._mesh.transform = None" in "if isinstance(actor._mesh, VedoVolume)" as future vedo release will need this - settings.py: set WHOLE_SCREEN = False - fix output path in examples/screenshot.py and video.py - pyproject.toml: a newer version of "morphapi>=0.2" seems to be needed
for more information, see https://pre-commit.ci
alessandrofelder
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks a lot for this @marcomusy
I made some tweaks to the tests to adapt to your changes and made other tiny suggestions.
Still some trouble with test_volumetric_data but I will keep investigating.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 86.18% 86.07% -0.11%
==========================================
Files 26 26
Lines 1209 1214 +5
==========================================
+ Hits 1042 1045 +3
- Misses 167 169 +2 ☔ View full report in Codecov by Sentry. |
|
Opened #294 for test that still doesn't pass - may well be the data we regress against in that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
matplotlib.pyplot as plt, this looks like a genuine bugclose()method accordinglyactor._mesh.transform = Noneinif isinstance(actor._mesh, VedoVolume)as future vedo release will need thisWHOLE_SCREEN = Falseas default, avoid settingsize='full'as this is poorly dealt with in vtkexamples/screenshot.pyandvideo.pyHow has this PR been tested?
Tested on the examples
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: