Fix rotation bug when exproting to html #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 26 26
Lines 1213 1213
=======================================
Hits 1048 1048
Misses 165 165 ☔ View full report in Codecov by Sentry. |
adamltyson
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
LGTM, thanks @IgorTatarnikov. I'll merge, release, then hopefully we should be able to close #315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
The meshes were mirrored when exporting to HTML, see #315.
What does this PR do?
Provides already transformed meshes to be rendered by k3d.
References
#315
How has this PR been tested?
The probe tracks were exported to HTML and visually inspected.
All other examples render correctly, and all tests pass.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: