Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple web export example #319

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Add simple web export example #319

merged 4 commits into from
Jan 15, 2024

Conversation

adamltyson
Copy link
Member

No description provided.

@adamltyson adamltyson requested a review from a team January 15, 2024 14:37
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (740398f) 86.15% compared to head (f8101f0) 86.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   86.15%   86.39%   +0.24%     
==========================================
  Files          26       26              
  Lines        1213     1213              
==========================================
+ Hits         1045     1048       +3     
+ Misses        168      165       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny suggestion to add some asymmetry.

Might help catch future bugs!

examples/web_export.py Outdated Show resolved Hide resolved
adamltyson and others added 2 commits January 15, 2024 15:42
Co-authored-by: Igor Tatarnikov <61896994+IgorTatarnikov@users.noreply.github.com>
@adamltyson adamltyson merged commit 7f305f0 into main Jan 15, 2024
19 checks passed
@adamltyson adamltyson deleted the export_example branch January 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants