Replace pandas.df.append with safe_concat
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reproduces #254 fails as expected with pandas 2.1.3 passes with pandas 1.5.3 a dummy volumes.csv created by cutting down version from registration_output data
regression data from pandas 1.5.3
avoid using hard-coded paths and writing tmp data to codebase
alessandrofelder
added
bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 23.31% 24.61% +1.30%
==========================================
Files 22 23 +1
Lines 1214 1235 +21
==========================================
+ Hits 283 304 +21
Misses 931 931 ☔ View full report in Codecov by Sentry. |
willGraham01
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Newer versions of
pandasbreak the analysis code, due to the deprecation and removal ofpandas.Dataframe.append.What does this PR do?
pandas.Dataframe.appendwithbrainglobe_utils.pandas.safe_concatinanalyse.get_region_totals()pandas1.5.3, ie before deprecation).References
Closes #254
How has this PR been tested?
pandas 1.5.3and test written.Is this a breaking change?
Nope
Does this PR require an update to the documentation?
Nope
Checklist: