Reinstate brainmapper ci check #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor metadata updates
Reinstate the CI check for
brainmapperFor the release of v1.0.0 we had to suppress the check on the
brainmappercommand-line interface, since we had a circular dependency:Workflows needs cellfinder v1.0.0 on PyPI to download it and test-run brainmapper -> cellfinder v1.0.0 can't check that brainmapper works since it needs the name available in workflows.
This PR reinstates the command-line tool check in our CI workflow.
This is something of a code duplication (ideally the CI in this repo would call some CI in workflows) but it safeguards us for now, and we can always set this up ourselves after the migration is complete.
Won't work until brainglobe-workflows is released with brainmapper available.