Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooling config #351

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Update tooling config #351

merged 3 commits into from
Jan 4, 2024

Conversation

adamltyson
Copy link
Member

  • Remove references to py38
  • Remove cibuildwheel config (unnecessary since the move to numba from Cython)
  • Move tox config to pyproject.toml to reduce number of config files and harmonise with the rest of BrainGlobe

@adamltyson adamltyson requested a review from a team January 3, 2024 17:16
willGraham01
willGraham01 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@willGraham01 willGraham01 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox seems happy when run locally, so approving 👍 (Had to merge in main due to another update)

@willGraham01 willGraham01 merged commit 84784e2 into main Jan 4, 2024
14 checks passed
@willGraham01 willGraham01 deleted the tooling branch January 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willGraham01 willGraham01 willGraham01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamltyson @willGraham01