Import header from brainglobe-utils #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
willGraham01
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
All looks good, the CLI fail is due to brainglobe-workflows needing an update based on an earlier cellfinder update.
So approving with a view for re-running the CLI once that issue is fixed: brainglobe/brainglobe-workflows#90
|
@willGraham01 I re-ran the checks, and all seem to pass now since #400 was merged. Are you happy to merge this PR now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
cellfindercurrently contains a copy of the html headers frombrainglobe_utilsWhat does this PR do?
This PR imports the headers from
brainglobe_utilsand removes any duplicates in this repo.Needs changes from brainglobe/brainglobe-utils#70
References
For #327
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: