Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellfinder test fix #400

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Cellfinder test fix #400

merged 1 commit into from
Apr 12, 2024

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Apr 12, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
'brainmapper' tests were failing due to a directory not existing before being writen to.

What does this PR do?
Now creates the directory tree before trying to write a config file.

References

Closees brainglobe/brainglobe-workflows#90

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

All tests pass on CI.

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

No

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

No

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder merged commit daa13e2 into main Apr 12, 2024
14 checks passed
@alessandrofelder alessandrofelder deleted the custom-config-fix branch April 12, 2024 15:34
@K-Meech K-Meech mentioned this pull request Apr 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants