Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support md5 password in terraform code #90

Closed
wants to merge 2 commits into from

Conversation

mikemlg
Copy link

@mikemlg mikemlg commented Oct 26, 2022

Currently we put the plain text password to the terraform code and it will be hashed by md5 (username + password).
#7

However, this feature removed the ability to use an md5 hash in the password field.

This MR allow user to put an md5 hashed password to prevent putting plain-text password in terraform code.

support md5 password in terraform code
@mtesch-um
Copy link
Contributor

Maybe also check for prefix of sha256? CREATE USER seems to take both, while ALTER USER seems to take only md5, based on docs, not actual experimentation: https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_USER.html

@mtesch-um
Copy link
Contributor

i ran into this again, and forgot someone already fixed it! thanks @mikemlg also see #96

@hoxu
Copy link
Contributor

hoxu commented Dec 5, 2022

PASSWORD { 'password' | 'md5hash' | 'sha256hash' | DISABLE }

Is there a reason why the password string is not simply passed as-is to CREATE USER, and let Redshift sort out whether it's a plaintext or hashed password?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants