hapi@15.1.1 breaks build 🚨 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works. Don't want to require latest version of hapi to use the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
hapi just published its new version 15.1.1.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As hapi is “only” a peerDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 756 commits .
4abea1e15.1.1b9b3578Merge pull request #3351 from hapijs/subtext-shrinkwrap15757ddFix subtext shrinkwrap054e9e2Merge branch 'master' of github.com:hapijs/hapi4f910d2Conditional connectionless mode. Closes #3350e688595Merge pull request #3343 from mtharrison/docaafb5a4Merge pull request #3342 from mtharrison/upgrade-shot1c12abbDocument request.connection60bade9Update hapijs/shot to 3.3.2 from 3.3.158485c015.0.409c9185Merge pull request #3339 from hapijs/restore-shrinkwrap7633977Restore npm-shrinkwrap.json to package. Closes #33382ec641aMerge branch 'master' of github.com:hapijs/hapi63f7d89Event timing. Closes #3330. Closes #3332f502385Merge pull request #3331 from jmm/request-path-docsThere are 250 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade