Skip to content

Commit

Permalink
After sequel 4.46.0, Deprecate calling filtering methods without an a…
Browse files Browse the repository at this point in the history
…rgument or a block

- jeremyevans/sequel@b861eb2

`User.filter{ true }.delete` works from  sequel-4.0.0 to sequel-5.2.0.
  • Loading branch information
troter committed Dec 1, 2017
1 parent db9d561 commit a481814
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions test/sequel_test.rb
Expand Up @@ -75,15 +75,15 @@ def validate
end

it 'saves value' do
User.filter.delete
User.filter{ true }.delete
user = User.new
user.sex = :female
user.save
user.sex.must_equal 'female'
end

it 'loads value' do
User.filter.delete
User.filter{ true }.delete
User.create(:sex => :male)
store_translations(:en, :enumerize => {:sex => {:male => 'Male'}}) do
user = User.first
Expand All @@ -98,7 +98,7 @@ def validate
end

it 'does not set default value for not selected attributes' do
User.filter.delete
User.filter{ true }.delete
User.create(:sex => :male)

assert_equal [:id], User.select(:id).first.values.keys
Expand All @@ -109,7 +109,7 @@ def validate
User.new.values[:lambda_role].must_equal 'admin'
end
it 'uses after_initialize callback to set default value' do
User.filter.delete
User.filter{ true }.delete
User.create(sex: 'male', lambda_role: nil)

user = User.where(:sex => 'male').first
Expand Down Expand Up @@ -193,7 +193,7 @@ def validate
end

it 'stores custom values for multiple attributes' do
User.filter.delete
User.filter{ true }.delete

klass = Class.new(User)
klass.enumerize :interests, in: { music: 0, sports: 1, dancing: 2, programming: 3}, multiple: true
Expand All @@ -208,7 +208,7 @@ def validate
end

it 'adds scope' do
User.filter.delete
User.filter{ true }.delete

user_1 = User.create(status: :active, role: :admin)
user_2 = User.create(status: :blocked)
Expand Down Expand Up @@ -238,15 +238,15 @@ def validate
end

it 'supports defining enumerized attributes on abstract class' do
Document.filter.delete
Document.filter{ true }.delete

document = Document.new
document.visibility = :protected
document.visibility.must_equal 'protected'
end

it 'supports defining enumerized scopes on abstract class' do
Document.filter.delete
Document.filter{ true }.delete

document_1 = Document.create(visibility: :public)
document_2 = Document.create(visibility: :private)
Expand All @@ -266,7 +266,7 @@ def validate
end

it "doesn't update record" do
Document.filter.delete
Document.filter{ true }.delete

expected = Time.new(2010, 10, 10)

Expand Down

0 comments on commit a481814

Please sign in to comment.