Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a duration threshold for statistical maps #100

Merged
merged 4 commits into from
Jul 24, 2018

Conversation

annesodub
Copy link
Contributor

This modification adds a duration field in the panel_stat to filter out periods of significance that does not exceed a duration threshold (in sec).

For instance in Kirchner et al. 2009 "Ultra-Rapid Sensory Responses in the Human Frontal Eye Field Region." (J. of Neurosc.) :

"Only periods significant for at least 5 ms consecutively were considered in all analyses"
This can only be achieved by having the possibility to filter out period of significance that does not exceed 5 ms in duration.

Please let me know if anything is wrong with the PR, I am a newbie.

Cheers,
AnneSo

…ficance that does not exceed a duration threshold (in sec)
@martcous
Copy link
Member

martcous commented Jul 9, 2018

Please change back the HTTP USC links to HTTPS.

@annesodub
Copy link
Contributor Author

How can I do that?

@martcous
Copy link
Member

martcous commented Jul 9, 2018

Change the http://neuroimage.usc.edu/ links in process_extract_pthresh.m to https://neuroimage.usc.edu/ links.

@annesodub
Copy link
Contributor Author

done

@ftadel
Copy link
Member

ftadel commented Jul 17, 2018

Wouldn't this be more readable and useful in milliseconds?
Are you ever going to be thresholding above 1s?

For aligning the two text boxes: add the constrain 'tab' when creating jTextDurThresh and jTextPThresh with gui_component. You could also display the units after the text box, as it is done in most of the interface.

@ftadel ftadel merged commit 96215ff into brainstorm-tools:master Jul 24, 2018
@ftadel
Copy link
Member

ftadel commented Jul 24, 2018

Many details fixed in: 0a3fa6e
(allowing the processing of source files, switching to ms instead of seconds, setting the default to 0s...)
The online documentation was updated as well.

@annesodub There is still the support for the time-frequency files to add. It is not working at the moment.

@ftadel
Copy link
Member

ftadel commented Jul 24, 2018

One more fix: 0a3fa6e

@annesodub annesodub deleted the dev_ASD branch September 24, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants