Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add more thorough documentation for braintree.setup #11

Closed
wants to merge 6 commits into from

Conversation

jeffcarp
Copy link

@jeffcarp jeffcarp commented Jan 7, 2015

This is a work in progress to add documentation for every parameter that can be passed to braintree.setup. Currently I don't think there is a full list of options anywhere.

I realize this would be most useful if it also lived in the main docs site. I couldn't find a page where it would fit logically so I'm starting here.

TODO:

  • paymentNonceReceived
  • finish PayPal options

@jeffcarp jeffcarp force-pushed the document-setup branch 2 times, most recently from dbab244 to 4fc19b0 Compare January 8, 2015 02:47
@jeffcarp
Copy link
Author

jeffcarp commented Jan 8, 2015

Looking through our docs, the options for PayPal are all nicely laid out in this list, which makes me hesitant about duplicating them here.

Nonetheless, we are lacking a full client-side reference, so I'm going to go ahead and dupe that content here in hopes that it helps that initiative. I'll copy over any updates that happen in the meantime.

@jeffcarp jeffcarp force-pushed the document-setup branch 6 times, most recently from 501d1f6 to 7e2f775 Compare January 8, 2015 03:40
@pdg137
Copy link

pdg137 commented Jan 13, 2015

This documentation is essential for anyone considering using drop-in, so I really hope that it will be merged into the official repository soon!

@jeffcarp
Copy link
Author

Update on this PR: after launching the server-side reference, we're talking about how to improve the client-side references. I will keep you updated on how that progresses, but it looks like this work stream will end up being merged with a future improved client-side reference.

@aaronrenner
Copy link

Thanks for starting on this. It would be very helpful to have these options documented. I had to look through your pull request and the minified source to find the paymentMethodNonceInputField option. It would be really helpful if all of the options were documented somewhere.

@sornon1
Copy link

sornon1 commented May 14, 2015

@aaronrenner all the options have been documented now in the public docs site. The global stuff is here and that particular option is here.

The team would love any feedback on the reorganization of the docs there.

@jeffcarp jeffcarp closed this Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants