-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BraintreeCancelListener.onCancel() is not called #63
Comments
Hey there, thanks for letting us know! I'll take a look tomorrow and get Steve
|
Hey @nzakharchenko, @quinnjn was able to pin down that bug this morning. We'll have a release out for this shortly. Thanks again for letting us know! Cheers, |
Hello @sdcoffey ! Thank you for information! Waiting for release :) BR, Nick |
Looks like there is a bigger problem in both v1 and v2 apis. If user cancel it will never call error or on cancel listeners. |
@vovkab: there was no cancel listener in v1 and canceling is not an error. It's left up to the integrator to handle the cancel in @nzakharchenko: the fix has been made and will be out in the next release. We're planning on releasing it early next week. |
@lkorth cool! thank you for information! |
@lkorth I know, but this is really strange decision. Since now we need to have 2-3 listeners and also handle cancel somewhere else. But anyway here is few bugs that is there live right now:
So if for some reasons The same or even more in V2:
p.s. Maybe there is a chance you could make library with a blocked calls, so we can build something on top of it, for example we could use RxJava and have just one onActivityResult blocking call to get result. This way we can avoid all this callback hell. |
The only time Changes have already been made for v2 and will be released early next week. |
Thanks @lkorth for a quick answer. About
As you can see if something wrong with json, it is broken again, it will return null, and we will never get error notification. |
In that case, there would have been errors before this point in the PayPal SDK and it would have never gotten this far without a response. We'll change it to return an error whenever |
@lkorth thanks! p.s. if there were more errors and you never get to this code, why do you need to return null or even check for a null? ;) |
@nzakharchenko the fix for this went out in @vovkab the fix on 1.x will be going out shortly. |
When I'm starting payment process on device with installed PayPal application, and after user press "Cancel" button or HW Back button - I'm not getting any notification about that. BraintreeCancelListener.onCancel() is not called like it is supposed to be.
In case when user doesn't have PayPal application and WebView started - it works correctly.
Starting payment like that:
PayPalRequest request = new PayPalRequest("1");
PayPal.requestOneTimePayment(mBraintreeFragment, request);
Configuration that I'm using:
compileSdkVersion 23
buildToolsVersion "23.0.2"
targetSdkVersion 23
compile "com.braintreepayments.api:braintree:2.0.1"
The text was updated successfully, but these errors were encountered: