Fixes for arm64 #21
Closed
Fixes for arm64 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2014 14:26
This test was only passing on 32 bit by chance. Changing the source string to `@"test dataa"` causes the test to fail on both 32 and 64 bit architectures. The problem is that `+[NSString stringWithUTF8String:]` expects a null-terminated, UTF-8 encoded C-string, but `encodedAesKey` is not guaranteed to meet this requirement. The solution is to use `-[NSString initWithBytes:length:encoding:]` and specify the length of the data explicitly.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.