Map to all paymentMethods for consistency of access. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 22, 2015 15:21
Updating the ability to call $customer->paymentMethods without referencing to the function. This way it is consistent with other payment method lookups and the documentation online: https://developers.braintreepayments.com/javascript+php/reference/response/payment-method
1) Iterating though search results The documentation does not seem to cover how to iterate through objects. Many developers perform a var_dump(), don't see the object data, and assume they need to then independently lookup each with a find request. This is not true. 2) Finding all customers funding options. Many developer will want to display to a customer a custom list of funding options. It is not correctly shown in the documentation you must use $customer->paymentMethods() as a function to get all. It is not shown that you can use isDefault() to check if this source is the default. It is also not obvious how to present a consistent label for the field as you loop though.
1) Iterating though search results The documentation does not seem to cover how to iterate through objects. Many developers perform a var_dump(), don't see the object data, and assume they need to then independently lookup each with a find request. This is not true. 2) Finding all customers funding options. Many developer will want to display to a customer a custom list of funding options. It is not correctly shown in the documentation you must use $customer->paymentMethods() as a function to get all. It is not shown that you can use isDefault() to check if this source is the default. It is also not obvious how to present a consistent label for the field as you loop though.
1) Iterating though search results The documentation does not seem to cover how to iterate through objects. Many developers perform a var_dump(), don't see the object data, and assume they need to then independently lookup each with a find request. This is not true. 2) Finding all customers funding options. Many developers will want to display to a customer a custom list of funding options. It is not correctly shown in the documentation you must use $customer->paymentMethods() as a function to get all. It is not shown that you can use isDefault() to check if this source is the default. It is also not obvious how to present a consistent label for the field as you loop though.
|
Hi, @may191. We incorporated your suggestion into release 3.1.0. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the ability to call $customer->paymentMethods without referencing to the function.
This way it is consistent with other payment method lookups and the documentation online:
https://developers.braintreepayments.com/javascript+php/reference/response/payment-method