Get rid of _resumeDetection method on the braille handler #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2018 19:49
|
@LeonarddeR Thanks, code looks good, but unable to test with a Focus device right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though I've not been able to test this yet, I hope that this will make things easier to understand and also fix the bug where the detector keeps the limitToDevices list when the connection drops. Flow is now as follows:
a. A usb device is connected, NVDA switches to it and detection is disabled until an error occurs
b. The bluetooth connection is lost. A rescan is triggered with limitToDevices set to None.