Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail Content fetched from an Url #2

Closed
m-idler opened this issue Oct 5, 2014 · 3 comments
Closed

E-Mail Content fetched from an Url #2

m-idler opened this issue Oct 5, 2014 · 3 comments

Comments

@m-idler
Copy link

m-idler commented Oct 5, 2014

Hello bramley,
I really like your plugin, it saved me lots of time. Unluckily I am facing a small problem with the plugin.

I created a new E-Mail message with the content from an Url. Everything with the placeholders worked fine, but when i go to the [VIEWBROWSER] page I just see the placeholder that contains the content url:

[URL:http://xyz]

As I'm not used to the plugin development of phplist I thought that you might be much faster at finding a solution. I guess that there are just a few extra lines of code needed:
after fetching the content of the message do a check if the content has just an url placeholder and in that case fetch the url and use its content.

Thank you very much in advance.
marcel

@bramley
Copy link
Owner

bramley commented Oct 5, 2014

I will take a look at what needs to be changed, but it probably isn't quite as straightforward as you might expect because the URL can contain placeholders that need to be replaced before fetching the URL.

bramley added a commit that referenced this issue Oct 5, 2014
@bramley
Copy link
Owner

bramley commented Oct 5, 2014

Actually it was straightforward. Please can you update your plugin from the Manage Plugins page.

@m-idler
Copy link
Author

m-idler commented Oct 9, 2014

Thank you very much for the really fast response and solution, the fix works perfectly (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants