Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lut validation action #2312

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Fix Lut validation action #2312

merged 3 commits into from
Jun 23, 2024

Conversation

LDprg
Copy link
Contributor

@LDprg LDprg commented Jun 22, 2024

After #2311 I noticed that there is a similar problem like before. The problem is not only that spaces are not correctly escaped, but () are also not properly escaped. This simply adds the code to fix this.

Hopefully then the CI/CD works out as expected.

@bramstroker
Copy link
Owner

@LDprg I did have a look into this. Further in this action only *.csv.gz files are relevant.
So I refactored to have the git diff limit on this in the first place. That eliminates the need to add all these escape sequences.
As the profile files never have spaces in the path.
Could you review this change please?

@bramstroker bramstroker changed the title Fix CI/CD again for #2288 Fix Lut validation action Jun 23, 2024
Copy link
Contributor Author

@LDprg LDprg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that's a much better approach. Maybe we should add double quotes just to be sure?

@bramstroker
Copy link
Owner

Ok that's a much better approach. Maybe we should add double quotes just to be sure?

Where do you want to add double quotes exactly? Unsure.
Could you add suggestion to the PR changes?

@LDprg
Copy link
Contributor Author

LDprg commented Jun 23, 2024

@bramstroker I added the suggested change. Now every file name should be double qouted, just for safety.

@bramstroker
Copy link
Owner

@bramstroker I added the suggested change. Now every file name should be double qouted, just for safety.

makes sense. thanks.

@bramstroker bramstroker merged commit c8554c9 into bramstroker:master Jun 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants