Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hue LWB006 and Belkin Wemo bulbs #75

Merged
merged 16 commits into from
Aug 17, 2021
Merged

Add Hue LWB006 and Belkin Wemo bulbs #75

merged 16 commits into from
Aug 17, 2021

Conversation

OzGav
Copy link
Contributor

@OzGav OzGav commented Aug 14, 2021

No description provided.

@nepozs
Copy link
Contributor

nepozs commented Aug 15, 2021

I'm sure that standby power draw is greater than 0W, so I can suggest to set it to 0.5W or measure correctly real power.

@bramstroker
Copy link
Owner

Yes the zigbee radio use a small amount of current. Typically it should be between 0.2 and 0.5 watt. However it's very difficult to measure this low current accurately, particullarly with cheap power meters.
@nepozs 0.3 seems a nice average to me.

@bramstroker
Copy link
Owner

Could be that the Belkin device uses even more power in standby, because it is a wifi device.

@OzGav
Copy link
Contributor Author

OzGav commented Aug 15, 2021

The Belkin is zigbee as well. I will change the standby for both to 0.3?

@bramstroker
Copy link
Owner

bramstroker commented Aug 15, 2021

Thanks a lot for your efforts into measuring this bulb.

Yes 0.3 seems fine to me.
I was thinking about introducing some new properties in the model.json file to indicate how the bulb was measured. This way we can refer to that in the future.

Following 3 properties:
measure_method: One of manual or script
measure_device: i.e. "Shelly plug S"
measure_description: Some extra explanation. You could add that you were not able to measure the standby usage and it was guessed to be 0.3 watt.

Let me know if you guys have any additions to this? You can add this to the model.json, than I will merge the PR.
Soon I'll update the bulbs I did myself. Maybe @nepozs and @CM000n can update their contributions.

@nepozs
Copy link
Contributor

nepozs commented Aug 16, 2021

I was thinking about introducing some new properties in the model.json file to indicate how the bulb was measured. This way we can refer to that in the future.

It is good idea, also "quality check" (eg. missing standby_power) is needed before publishing, as it will be harder to fix many incomplete files.

BTW IMHO if someone could not measure, it should be set to 0.4W (as it is closest to real value in case of Zigbee bulbs from all generations before "combo" Zigbee + BLE), in case other technologies like WiFi it can be even greater.

@OzGav
Copy link
Contributor Author

OzGav commented Aug 16, 2021

OK I have added those extra properties. I am happy with 0.3 or 0.4 whatever you guys decide.

@bramstroker
Copy link
Owner

OK I have added those extra properties. I am happy with 0.3 or 0.4 whatever you guys decide.

I agree with @nepozs to set it to 0.4

@OzGav
Copy link
Contributor Author

OzGav commented Aug 17, 2021

OK changed to 0.4 :-)

@bramstroker
Copy link
Owner

Thanks a lot, let's merge

@bramstroker
Copy link
Owner

I see the build is failing. the model.json files are invalid.
You must add comma's after each line.
You can use https://jsonlint.com/ to validate the json.

@OzGav
Copy link
Contributor Author

OzGav commented Aug 17, 2021

Yep sorry. Fixed.

@bramstroker bramstroker merged commit 74a45a1 into bramstroker:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants