Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_support_for_signify_LCE002 #84

Merged
merged 8 commits into from
Aug 18, 2021
Merged

add_support_for_signify_LCE002 #84

merged 8 commits into from
Aug 18, 2021

Conversation

CM000n
Copy link
Contributor

@CM000n CM000n commented Aug 17, 2021

Add support for Signify LCE002:
https://zigbee.blakadder.com/Philips_LCE002.html

@CM000n
Copy link
Contributor Author

CM000n commented Aug 17, 2021

Hi @bramstroker. Looks like the pull request was not successful, because the model.json now requires more information? Unfortunately the output from the github check is not really helpful. Are all of the parameters listed in the "model_schema.json" in the data directory now mandatory?
Or is something generally going wrong with the configuration of the json-schema-validator right now?

@bramstroker
Copy link
Owner

Yes, more parameters are required. Have another look at model_schema.json, there is a key required which lists all the required properties. You must add all the measure_ properties.

The github action Is created should validate and provide info as a comment in the PR, but this is not working yet unfortunately. Need to have another look into this. Seems permission related.

@bramstroker
Copy link
Owner

Also see #75 changes and comments for more explanation

@bramstroker bramstroker merged commit 3643ef4 into bramstroker:master Aug 18, 2021
@bramstroker
Copy link
Owner

Thanks!

@CM000n
Copy link
Contributor Author

CM000n commented Aug 18, 2021

No problem. But the Github action still failed. Or was that now due to the permission issues?

@bramstroker
Copy link
Owner

Yes I know. Still working on that. But I'm ill from vaccination, so will be a few days when I can have a look again

@CM000n
Copy link
Contributor Author

CM000n commented Aug 18, 2021

Take care of yourself. That definitely comes first. Get well soon and recover quickly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants