Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake5 - Next #19

Open
wants to merge 11 commits into
base: cake5
Choose a base branch
from
Open

Cake5 - Next #19

wants to merge 11 commits into from

Conversation

bor-attila
Copy link
Contributor

@bor-attila bor-attila commented Mar 21, 2024

I made some modifications, but I was not able to finish.

  • I removed the ConfigDefaults class and I used the Helper's default config method. (Helpers uses InstanceConfigTrait)
  • all config related to prod/dev removed, now you must use explicitly: Environment::PRODUCTION or Environment::DEVELOPMENT . For detector Environment::FROM_DETECTOR can be used. Not tested yet. lol
  • if production is set, and no manifest file - no more exception - but actually this should maybe optional (!?)
  • The Helper completly reworked
    Since the environment is explicitly defined the prodFilter and devFiles is unnecessary
    You can add files (scripts/css) separetly to 'prod' or 'env' or 'both'
  • Updated README - still not complete yet
  • Updated examples file. exple: changed webroot_src to resources
  • Added render mode for 'lazy' rendering - disabled by default

TODO:

If you think is too much - feel free to modify and/or delete. Enjoy the bugs.

UPDATE1:

  • fixed CS
  • I removed the parallel option from composer cs-check because the plugin isn't large enough to warrant it. Additionally, for some reason, it's not working for me.

@bor-attila bor-attila marked this pull request as ready for review March 22, 2024 03:33
@tyler36
Copy link

tyler36 commented Aug 21, 2024

I'm interested in getting Vite/TailwindCSS intergrated into a CakePHP project.
Are you still working on this? What is the best way I can help test this?

@passchn
Copy link
Collaborator

passchn commented Aug 25, 2024

@tyler36 You can integrate vite and tailwind perfectly fine with the current version of this plugin. I am using tailwind myself. This PR is for a new major release to fix some design issues. I was however not taking the time to look into this for some reasons. If you have specific questions about integrating tailwind, you could open a new issue or DM me on the CakePHP Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants