Handle future default donation amount changes #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date_default_amounts' Closes #2584
yachtcaptain23
force-pushed
the
feature/default_donation_amounts
branch
from
ec7c0e8
to
8d61f1b
Compare
| @@ -0,0 +1,6 @@ | |||
| class DropNullableRequirementFromSiteBanners < ActiveRecord::Migration[6.0] | |||
| def change | |||
| change_column_null :site_banners, :donation_amounts, true | |||
There was a problem hiding this comment.
Have you checked the Site Banner code to see what happens when someone creates a new account / channel with a nil site banner? I think I remember that any new site banner creates with a tip set
There was a problem hiding this comment.
Yeah it works just fine.
|
I don't think we should let handlebars-lang/handlebars.js#1658 block this |
corymcdonald
approved these changes
Mar 18, 2020
corymcdonald
added a commit
to corymcdonald/publishers
that referenced
this pull request
Jun 26, 2020
* Initial commit * Subscribe to marketing emails on GDPR * Add subscription to marketing emails * Update secrets * Create permissions for mailing list for marketing Closes #2378 * Remove dead code * Fix cassettes * Fix labels for payout in progress. Closes #2415 (brave-intl#2421) * Fix UI. Closes #2415 * Update serialized-javascript (brave-intl#2427) * Update serialized-javascript * Update puma * Upgrade node version * Use different travis version * Use nvmrc * Ignore pre-installed defaults * Fix wrong amount being displayed. Closes #2425 (brave-intl#2429) * Fix channel transfer bug. Closes #2400 (brave-intl#2435) * Fix channel transfer bug. Closes #2400 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Resolve JS Vulnerabilities (brave-intl#2443) * JS Vulns * Remove peerDependencies warning * Upgrade webpacker * Reverse sort the Statements (brave-intl#2444) * Use updated locale and remove unused one. Copied from https://github.com/tigrish/devise-i18n (brave-intl#2439) * Add Rate Card information to statements (brave-intl#2431) * Add Rate Card information to statements * Piwik analytics * Use end_date instead of start_date (brave-intl#2445) * Feature/sign in as user with modal (brave-intl#2441) * Sign in as the user. Closes #2419 * Bump rack from 2.0.7 to 2.0.8 (brave-intl#2451) Bumps [rack](https://github.com/rack/rack) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@2.0.7...2.0.8) Signed-off-by: dependabot[bot] <support@github.com> * Add TOS on Sign up, visual fixes (brave-intl#2452) * Add terms of service on homepage * Show groups for downloads / installs (brave-intl#2428) * Unify controllers for PromoRegistrations * Selectable install, download, and finalized counts * Track eyeshade confirmed too * Fix build * Captialize the enums * Rename Stats to be ReferralStats * UI Changes * Don't blow up if nil Co-authored-by: Albert Wang <amwang217@gmail.com> * Bugfix/japanese locale youtube channel addition (brave-intl#2457) * Fix adding Youtube channels for Japanese locale Closes #2456 * Continue making calls to eyeshade for wallet balance. Closes #2454. (brave-intl#2455) * Continue making calls to eyeshade for wallet balance. Closes #2454. * Remove invalid test * Sort on downloads, installs, and confirmations for unattached promo for admin. (brave-intl#2460) Closes #2458 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> Co-authored-by: Cory McDonald <cory@corywmcdonald.com> * Change pending label to 'Minimum balance for payout is X currency'. C… (brave-intl#2433) * Change pending label to 'Minimum balance for payout is X currency'. Closes #2387 * Update config/locales/ja.yml * Feature: Paypal UI (brave-intl#2363) * Specify paypal connection as active only. * PayPal UI on home * Include rubocop on new files * Support BAT points translation. Closes #2357 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Don't use an obscure website for ssl testing (brave-intl#2469) * Don't use an obscure website for ssl testing * Require https when testing against badssl.com * Access base url from anywhere (brave-intl#2470) 🐛 Use base url for paypal redirect * Properly handle redirect for users with a Japanese Paypal account. Closes #2473 (brave-intl#2474) * Reduce complexity in referral reports (brave-intl#2461) * Reduce complexify when generating referral reports * Fix reporting interval * Create Payment Message for reporting (brave-intl#2471) * Create Payment Message for reporting * Remove true * Update app/services/publisher_wallet_getter.rb Co-Authored-By: Albert Wang <amwang217@gmail.com> * Remove test @payout_message * Move job to Sidekiq * Move back to scheduler * Update tests Co-authored-by: Albert Wang <amwang217@gmail.com> * Improve reliability of promo registration stats sync. Closes #2478 (brave-intl#2479) * Improve reliability of promo registration stats sync. Closes #2478 Co-authored-by: Cory McDonald <cory@corywmcdonald.com> * Fix method call while calling sanitize order. Closes #2484 (brave-intl#2485) * Upgrade node-sass to 4.3.1 (brave-intl#2490) * Upgrade node-sass to 4.3.1 * Fix travis build * Don't double log errors. Closes #2487 (brave-intl#2488) * Channels v3.1 which includes the publisher ads (brave-intl#2464) * Channels v3.1 which includes the publisher ads Closes #2462 * Fix naming for new channels list (brave-intl#2493) * Make slider margin look proportionate (brave-intl#2496) * Make slider look right * Fix cron job * Remove unused portion of code. Fix which redis key is being used * Bugfix/routing loading (brave-intl#2497) * Fix routing for api/v3_p1/public/channels * Include results to excluded sites * Report generation for paypal (brave-intl#2494) * Report generation for paypal Refactor based on @nvonpentz's comments * Use one transaction for save (brave-intl#2502) * Use one transaction for save * Fix parsing for stats by date * String changes to address deposit currency or token. Closes #2489 (brave-intl#2498) * Increase connection pool size for Redis. Closes #2328 (brave-intl#2510) * Fix Sidekiq UI (brave-intl#2511) * Have auth on staging (brave-intl#2513) * Fix dyno loading * Don't run the long running caching job if it happened within the past 2 hours * Temporarily disable PayoutReport#index until we setup follower db connection * Fix updated_at timestamp. Closes #2518 * Tighten query for empty jsonb array on stats column Closes #2520 * Use the right country designation for country * Fix tests * Fix Locked Check on Payout Helper (brave-intl#2524) * Use access token instead for payout * Store payer_id * Store payer_id in address field * Fixed test * Use transaction group id Closes #2531 * Filter out email addresses for resend_authentication_email * Create Internal API for Uphold Transactions (brave-intl#2534) * Create Internal API for Uphold Transactions * Use channel identifier instead * Fix another flappy test (brave-intl#2525) * Fix another flappy test * Fix rate limit on registration (brave-intl#2538) * Fix rate limit on registration * Remove emoji 😩😭 * Update app/controllers/api/v1/transactions_controller.rb Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Update app/controllers/api/v1/transactions_controller.rb Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Translate pub ads * Allow fetching from behind heroku forwarding * Make search a little better (brave-intl#2543) * Make search a little better * move is_a_uuid? * Upgrade brave ui to 0.38.0. UI should load on development now (brave-intl#2467) * Upgrade brave ui to 0.38.0. UI should load on development now * Translations for site banners * Remote ip test by stringifying (brave-intl#2548) * Revert "Remote ip test by stringifying (brave-intl#2548)" (brave-intl#2552) This reverts commit 834bf81. * Revert "Allow fetching from behind heroku forwarding" (brave-intl#2553) * modified typo in translation * Add ability to snooze Uphold Emails (brave-intl#2545) * Bump nokogiri from 1.10.7 to 1.10.8 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.7 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.7...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com> * Puma fix * Use 1,10,100 as default tip amounts (brave-intl#2561) * Use 1,10,100 as default tip amounts * Upgrade kind-of (brave-intl#2573) * Upgrade kind-of * Update additional packages * Update lint * Fix naming * Fix typing * Change TSLint * Fix statements. Closes #2570 (brave-intl#2576) * Bump acorn from 5.7.3 to 5.7.4 in /public/creators-landing Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> * Revert "Use 1,10,100 as default tip amounts (brave-intl#2561)" (brave-intl#2582) This reverts commit fc6ba27. * Revert "Revert "Use 1,10,100 as default tip amounts (brave-intl#2561)" (brave-intl#2582)" (brave-intl#2585) This reverts commit d50da67. * Handle future default donation amount changes (brave-intl#2586) * Rake task to update previous values to new ones. 'rake site_banner:update_default_amounts' Closes #2584 * Feature flags and special payments (brave-intl#2559) Closes #2540 Closes #2546 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Upgrade gemfile (brave-intl#2590) * Protect against thundering herd problem by only allowing 1 request at… (brave-intl#2589) * Protect against thundering herd problem by only allowing 1 request at a time * Cast to int. Closes #2592 * Limit annoying emails (brave-intl#2588) * Limit annoying emails * Wider coverage on rack attack for emails * Cover resend_authentication_email * Remove unused package: handlebars (brave-intl#2595) * Remove unused package: handlebars * Tighten travis.yml * Fix tests * Fix linting * Update redis url. Also had updated in the env variables on travis too * Get rid of false positive from husky pre-commit * Fix missing key. Closes #2599 * Feature: Sign-in as a browser user. Closes #2550 (brave-intl#2598) * Feature: Sign-in as a browser user. Closes #2550 * IP whitelist only Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Fix params (brave-intl#2608) * Fix webp image bug (brave-intl#2607) * changes .bottom-swoop width from 100vw to 100% (brave-intl#2605) * Fix attribute translation bug (brave-intl#2606) * Use a separate route for peer-to-peer (brave-intl#2611) * Use a separate route for peer-to-peer * Bugfix/double slash (brave-intl#2613) * Fix double slash * Fix id for promo_campaign lookup * Fix assets being loaded (brave-intl#2614) * Define image more explicitly * Use yarn install --production and upgraded some node packages (brave-intl#2604) * Use yarn install --production and upgraded some node packages * Update packages for landing page * Add slash to match staging env * Bugfix/promo fails to create (brave-intl#2616) * Handles rare scenario where promo server doesn't create a promo registration * Update puma. Update offline aka local scenario * Move Invoice to feature flag (brave-intl#2612) * Update count of content creator accounts to 500,000 (brave-intl#2603) * Better lookup of invoices (brave-intl#2618) * Update publishers_status_updates API Return the status_update ID in the response upon sucessfull API call * Remove unused gems. Remove possible unused initializer (brave-intl#2630) * Remove unused gems. Remove possible unused initializer * We're hitting the API limit on youtube. Closes #2636. (brave-intl#2637) * We're hitting the API limit on youtube. Closes #2636. * Only store stats against half the users * Fix CSS for out-of-place copy button (brave-intl#2628) * Fix CSS for out-of-place copy button * Eliminate erroneous devise flash messages. Closes #2620 (brave-intl#2625) * Eliminate erroneous devise flash messages. Closes #2620 * Updated comments for future review * Use follower database for reads on certain queries (brave-intl#2503) * Use follower database for reads on certain queries * Fix config * Optionally run rake db:setup * Disable automatic switching since GET requests sometimes saves stuff like UserAuthenticationTokens * Enable peer to peer for everyone (brave-intl#2640) * Redirect to production for staging * Initial testing commit * Larger channels list on staging * Specify fake channels for testing * Fix #2643 * Update cache_browser_channels_json_job_v3.rb * Fix readonly setup (brave-intl#2649) * Change tos link * Create snapshots (brave-intl#2648) * Create snapshots * Get it to pass stub tests with EAFP since they aren't relevant * Added simple TOS flow * Updated CSS * Include payout_report_id as param for post (brave-intl#2653) * Add a slash * Add content-type to header * Caps referral amounts for P2P and feature-flagged creators (brave-intl#2624) Closes #2596 * Decrease the number of pings we use for site channel verifications. * V3 channels with pagination * Support status 204 * Fix array substring for V3 API * Include cap for peer-to-peer * Resolve 2FA Issue (brave-intl#2670) * Case System improvements (brave-intl#2627) * General Case System improvements * Remove Organizations from the sidebar * Cases status update * Add index * Alberts great suggestion * Add more clarity to Statements (brave-intl#2638) * Add more clarity to Statements * Add comment describing fees * Format date on front end * Limit the length of a name (brave-intl#2671) * Limit the length of a name * Downcase the pending email * Change when jobs get enqueued (brave-intl#2676) * Temporary patch on rate limits * Syncs late at night to prevent API limit hits * Fix JS Vulnerabilities (brave-intl#2677) * Bugfix/rate limit (brave-intl#2675) * Fix youtube rate limit * No longer need to store channel stats * remove from sidekiq * Fix admin payment page (brave-intl#2678) * Fix manual payout report job (brave-intl#2683) * Cache Uphold Tips (brave-intl#2682) * Remove requests to prevent excess data use (brave-intl#2689) * Remove requests to prevent excess data use * Eliminate rack-attack limits for public API. We protect against thundering herd by limiting the number of requests that can try to access publishers (brave-intl#2693) * Fix Statement Bugs (brave-intl#2690) * Have warning for the quota (brave-intl#2692) * Rails gem update (brave-intl#2699) * Rack attack update * Updated assets * Upgrade to ruby 2.7.1 (brave-intl#2664) * Upgrade to ruby 2.7.1 * Support changes to BigDecimal * Updated dependencies * Use URI.encode_www_form_component instead of URI.escape since it's now deprecated * Add unique index for Uphold Transaction ID (brave-intl#2701) * Upgrade Twitch Gem (brave-intl#2702) * Backfill Publisher Statuses (brave-intl#2703) * Create Merchant Feature (brave-intl#2622) * Upgrade rails to 6.0.3.1 (brave-intl#2712) * Upgrade rails to 6.0.3.1 * Upgade yarn package * Close the connection after setnx is called. Related to redis/redis-rb#524 (brave-intl#2711) * Fix compilation issues (brave-intl#2714) * Fix compilation issues * Update jest-styled-components * Fix symbol underscore bug (brave-intl#2716) * Bump puma from 4.3.4 to 4.3.5 (brave-intl#2718) Bumps [puma](https://github.com/puma/puma) from 4.3.4 to 4.3.5. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](https://github.com/puma/puma/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified typos in Japanese translation %{brave_publisher_id} wasn't expanded. @yachtcaptain23 Could you please check the line 853? * Add quotes * Don't ping promo so much (brave-intl#2721) * Speed up site banner lookup * Don't use full table scan against different tables. This might not be the conclusive fix though since search test still needs to be done. (brave-intl#2725) * Fix perf issue when looking up contested_by_channel_id (brave-intl#2724) * DB improvements for pagination without needing full table scan (brave-intl#2728) * Feature: V4 Channels prefix list. Major performance improvements focus (brave-intl#2697) * Feature: V4 Channels prefix list. Major performance improvements focus for both server side costs and client side computation. * Use new version of S3 privacy preserving asset serving. * Fix the URL used. Fix the rake task for v4 to use all channels. (brave-intl#2734) * Change http to https on meta og:url tag (brave-intl#2735) * Download on campaign for unattached promos (brave-intl#2736) * Download on campaign for unattached promos * Fixed naming scheme to be more RESTful (brave-intl#2737) * Bump websocket-extensions from 0.1.4 to 0.1.5 (brave-intl#2738) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-ruby) from 0.1.4 to 0.1.5. - [Release notes](https://github.com/faye/websocket-extensions-ruby/releases) - [Changelog](https://github.com/faye/websocket-extensions-ruby/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-ruby@0.1.4...0.1.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump websocket-extensions in /public/creators-landing Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> * Bump websocket-extensions from 0.1.3 to 0.1.4 (brave-intl#2740) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix .rubocop.yml Warnings (brave-intl#2739) * Fix lookup of which channels get included in the prefix list * Lock down gem versions (brave-intl#2744) * Require KYC to enroll in promo registrations (brave-intl#2733) * Remove library not used in production (brave-intl#2752) * Include channels with no uphold verification connection to be enqueued in Cache::BrowserChannels::Main. * Add mock data for staging environment (brave-intl#2760) * Add mock data for staging environment * Update gem * Update app/jobs/cache/browser_channels/prefix_list.rb Co-authored-by: Cory McDonald <cmcdonald@brave.com> Co-authored-by: Cory McDonald <cmcdonald@brave.com> * Upgrade Rails to 6.0.3.2 (brave-intl#2762) * Refactor/renaming publisher prefix list (brave-intl#2764) Rename PublisherList to PublisherPrefixList * Use the 1-hop Fastly & rewards bucket for hosting rather than using 2 hops. (brave-intl#2766) * Wallet state expanded (brave-intl#2771) * Refactor to load wallet state at generation time * Closes #2773 * Remove unused column (brave-intl#2776) * Add check for deleted cards (brave-intl#2763) Co-authored-by: Albert Wang <amwang217@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chkk525 <r.chikaki@gmail.com> Co-authored-by: Jacob Lamont <cob@jacoblamont.com> Co-authored-by: Jacob Lamont <jlamont@brave.com> Co-authored-by: Nick von Pentz <nickvonpentz@gmail.com>
corymcdonald
pushed a commit
to corymcdonald/publishers
that referenced
this pull request
Jun 29, 2020
commit 4a18422 Merge: 38d8d51 31f1eef Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 16:56:23 2020 -0500 Merge remote-tracking branch 'origin/staging' into actions-test commit 38d8d51 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 16:39:32 2020 -0500 Rename and remove travis commit 1a961d6 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 16:35:59 2020 -0500 yaml bad commit 00682c7 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 16:35:16 2020 -0500 Bundle cache commit f881ae5 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 16:21:08 2020 -0500 more VCR stuff commit 4a1df2a Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 15:27:43 2020 -0500 Remove throttle from job commit 31f1eef Author: Albert Wang <amwang217@gmail.com> Date: Mon Jun 29 13:23:52 2020 -0700 Only add SiteBannerLookups for verified channels only (brave-intl#2781) * Only add SiteBannerLookups for verified channels only * Fix wrong address being used * Remove unused method commit 439aa21 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 14:32:08 2020 -0500 Remove Traffic Control commit 82712ff Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 14:05:50 2020 -0500 Continue removing redis as a dependency commit bfb440e Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 14:03:57 2020 -0500 Fix channel transfers (brave-intl#2761) commit 496ca39 Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 13:00:23 2020 -0500 Remove dependency on redis commit a45b49d Author: Cory McDonald <cmcdonald@brave.com> Date: Mon Jun 29 12:50:04 2020 -0500 Check value in initializer commit 0c45fcc Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 19:05:48 2020 -0500 Update browser_channels_dyno_caching.rb commit 57e7185 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 18:48:33 2020 -0500 Update test.rb commit 83350e1 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 18:36:01 2020 -0500 Update browser_channels_dyno_caching.rb commit 75e59c9 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 18:21:16 2020 -0500 Update test.rb commit 62d945b Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 17:50:53 2020 -0500 Add yarn commit ff20bb1 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 17:39:33 2020 -0500 Update ruby.yml commit 8c5d424 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 17:26:27 2020 -0500 Update ruby.yml commit 169cacd Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 17:07:03 2020 -0500 Update ruby.yml commit 88b94ca Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:51:33 2020 -0500 Update ruby.yml commit 6f59620 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:43:45 2020 -0500 Update ruby.yml commit 76eb704 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:37:30 2020 -0500 datbaase_url commit 96d8110 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:37:20 2020 -0500 datbaase_url commit 18f2299 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:24:10 2020 -0500 try this password commit 2b8ab49 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:16:18 2020 -0500 empty postgres password? commit 4e98b20 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:11:56 2020 -0500 Add postgres commit 6e45839 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:01:23 2020 -0500 Update ruby.yml commit 9308cb7 Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 16:00:51 2020 -0500 Update Ruby-versino commit a2941eb Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 15:58:18 2020 -0500 Update ruby.yml commit 861fb8f Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 15:52:57 2020 -0500 Create ruby.yml commit 618528f Author: Cory McDonald <cory@corywmcdonald.com> Date: Fri Jun 26 15:42:16 2020 -0500 done (#16) * Initial commit * Subscribe to marketing emails on GDPR * Add subscription to marketing emails * Update secrets * Create permissions for mailing list for marketing Closes #2378 * Remove dead code * Fix cassettes * Fix labels for payout in progress. Closes #2415 (brave-intl#2421) * Fix UI. Closes #2415 * Update serialized-javascript (brave-intl#2427) * Update serialized-javascript * Update puma * Upgrade node version * Use different travis version * Use nvmrc * Ignore pre-installed defaults * Fix wrong amount being displayed. Closes #2425 (brave-intl#2429) * Fix channel transfer bug. Closes #2400 (brave-intl#2435) * Fix channel transfer bug. Closes #2400 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Resolve JS Vulnerabilities (brave-intl#2443) * JS Vulns * Remove peerDependencies warning * Upgrade webpacker * Reverse sort the Statements (brave-intl#2444) * Use updated locale and remove unused one. Copied from https://github.com/tigrish/devise-i18n (brave-intl#2439) * Add Rate Card information to statements (brave-intl#2431) * Add Rate Card information to statements * Piwik analytics * Use end_date instead of start_date (brave-intl#2445) * Feature/sign in as user with modal (brave-intl#2441) * Sign in as the user. Closes #2419 * Bump rack from 2.0.7 to 2.0.8 (brave-intl#2451) Bumps [rack](https://github.com/rack/rack) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@2.0.7...2.0.8) Signed-off-by: dependabot[bot] <support@github.com> * Add TOS on Sign up, visual fixes (brave-intl#2452) * Add terms of service on homepage * Show groups for downloads / installs (brave-intl#2428) * Unify controllers for PromoRegistrations * Selectable install, download, and finalized counts * Track eyeshade confirmed too * Fix build * Captialize the enums * Rename Stats to be ReferralStats * UI Changes * Don't blow up if nil Co-authored-by: Albert Wang <amwang217@gmail.com> * Bugfix/japanese locale youtube channel addition (brave-intl#2457) * Fix adding Youtube channels for Japanese locale Closes #2456 * Continue making calls to eyeshade for wallet balance. Closes #2454. (brave-intl#2455) * Continue making calls to eyeshade for wallet balance. Closes #2454. * Remove invalid test * Sort on downloads, installs, and confirmations for unattached promo for admin. (brave-intl#2460) Closes #2458 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> Co-authored-by: Cory McDonald <cory@corywmcdonald.com> * Change pending label to 'Minimum balance for payout is X currency'. C… (brave-intl#2433) * Change pending label to 'Minimum balance for payout is X currency'. Closes #2387 * Update config/locales/ja.yml * Feature: Paypal UI (brave-intl#2363) * Specify paypal connection as active only. * PayPal UI on home * Include rubocop on new files * Support BAT points translation. Closes #2357 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Don't use an obscure website for ssl testing (brave-intl#2469) * Don't use an obscure website for ssl testing * Require https when testing against badssl.com * Access base url from anywhere (brave-intl#2470) 🐛 Use base url for paypal redirect * Properly handle redirect for users with a Japanese Paypal account. Closes #2473 (brave-intl#2474) * Reduce complexity in referral reports (brave-intl#2461) * Reduce complexify when generating referral reports * Fix reporting interval * Create Payment Message for reporting (brave-intl#2471) * Create Payment Message for reporting * Remove true * Update app/services/publisher_wallet_getter.rb Co-Authored-By: Albert Wang <amwang217@gmail.com> * Remove test @payout_message * Move job to Sidekiq * Move back to scheduler * Update tests Co-authored-by: Albert Wang <amwang217@gmail.com> * Improve reliability of promo registration stats sync. Closes #2478 (brave-intl#2479) * Improve reliability of promo registration stats sync. Closes #2478 Co-authored-by: Cory McDonald <cory@corywmcdonald.com> * Fix method call while calling sanitize order. Closes #2484 (brave-intl#2485) * Upgrade node-sass to 4.3.1 (brave-intl#2490) * Upgrade node-sass to 4.3.1 * Fix travis build * Don't double log errors. Closes #2487 (brave-intl#2488) * Channels v3.1 which includes the publisher ads (brave-intl#2464) * Channels v3.1 which includes the publisher ads Closes #2462 * Fix naming for new channels list (brave-intl#2493) * Make slider margin look proportionate (brave-intl#2496) * Make slider look right * Fix cron job * Remove unused portion of code. Fix which redis key is being used * Bugfix/routing loading (brave-intl#2497) * Fix routing for api/v3_p1/public/channels * Include results to excluded sites * Report generation for paypal (brave-intl#2494) * Report generation for paypal Refactor based on @nvonpentz's comments * Use one transaction for save (brave-intl#2502) * Use one transaction for save * Fix parsing for stats by date * String changes to address deposit currency or token. Closes #2489 (brave-intl#2498) * Increase connection pool size for Redis. Closes #2328 (brave-intl#2510) * Fix Sidekiq UI (brave-intl#2511) * Have auth on staging (brave-intl#2513) * Fix dyno loading * Don't run the long running caching job if it happened within the past 2 hours * Temporarily disable PayoutReport#index until we setup follower db connection * Fix updated_at timestamp. Closes #2518 * Tighten query for empty jsonb array on stats column Closes #2520 * Use the right country designation for country * Fix tests * Fix Locked Check on Payout Helper (brave-intl#2524) * Use access token instead for payout * Store payer_id * Store payer_id in address field * Fixed test * Use transaction group id Closes #2531 * Filter out email addresses for resend_authentication_email * Create Internal API for Uphold Transactions (brave-intl#2534) * Create Internal API for Uphold Transactions * Use channel identifier instead * Fix another flappy test (brave-intl#2525) * Fix another flappy test * Fix rate limit on registration (brave-intl#2538) * Fix rate limit on registration * Remove emoji 😩😭 * Update app/controllers/api/v1/transactions_controller.rb Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Update app/controllers/api/v1/transactions_controller.rb Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Translate pub ads * Allow fetching from behind heroku forwarding * Make search a little better (brave-intl#2543) * Make search a little better * move is_a_uuid? * Upgrade brave ui to 0.38.0. UI should load on development now (brave-intl#2467) * Upgrade brave ui to 0.38.0. UI should load on development now * Translations for site banners * Remote ip test by stringifying (brave-intl#2548) * Revert "Remote ip test by stringifying (brave-intl#2548)" (brave-intl#2552) This reverts commit 834bf81. * Revert "Allow fetching from behind heroku forwarding" (brave-intl#2553) * modified typo in translation * Add ability to snooze Uphold Emails (brave-intl#2545) * Bump nokogiri from 1.10.7 to 1.10.8 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.7 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.7...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com> * Puma fix * Use 1,10,100 as default tip amounts (brave-intl#2561) * Use 1,10,100 as default tip amounts * Upgrade kind-of (brave-intl#2573) * Upgrade kind-of * Update additional packages * Update lint * Fix naming * Fix typing * Change TSLint * Fix statements. Closes #2570 (brave-intl#2576) * Bump acorn from 5.7.3 to 5.7.4 in /public/creators-landing Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> * Revert "Use 1,10,100 as default tip amounts (brave-intl#2561)" (brave-intl#2582) This reverts commit fc6ba27. * Revert "Revert "Use 1,10,100 as default tip amounts (brave-intl#2561)" (brave-intl#2582)" (brave-intl#2585) This reverts commit d50da67. * Handle future default donation amount changes (brave-intl#2586) * Rake task to update previous values to new ones. 'rake site_banner:update_default_amounts' Closes #2584 * Feature flags and special payments (brave-intl#2559) Closes #2540 Closes #2546 Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Upgrade gemfile (brave-intl#2590) * Protect against thundering herd problem by only allowing 1 request at… (brave-intl#2589) * Protect against thundering herd problem by only allowing 1 request at a time * Cast to int. Closes #2592 * Limit annoying emails (brave-intl#2588) * Limit annoying emails * Wider coverage on rack attack for emails * Cover resend_authentication_email * Remove unused package: handlebars (brave-intl#2595) * Remove unused package: handlebars * Tighten travis.yml * Fix tests * Fix linting * Update redis url. Also had updated in the env variables on travis too * Get rid of false positive from husky pre-commit * Fix missing key. Closes #2599 * Feature: Sign-in as a browser user. Closes #2550 (brave-intl#2598) * Feature: Sign-in as a browser user. Closes #2550 * IP whitelist only Co-Authored-By: Cory McDonald <cmcdonald@brave.com> * Fix params (brave-intl#2608) * Fix webp image bug (brave-intl#2607) * changes .bottom-swoop width from 100vw to 100% (brave-intl#2605) * Fix attribute translation bug (brave-intl#2606) * Use a separate route for peer-to-peer (brave-intl#2611) * Use a separate route for peer-to-peer * Bugfix/double slash (brave-intl#2613) * Fix double slash * Fix id for promo_campaign lookup * Fix assets being loaded (brave-intl#2614) * Define image more explicitly * Use yarn install --production and upgraded some node packages (brave-intl#2604) * Use yarn install --production and upgraded some node packages * Update packages for landing page * Add slash to match staging env * Bugfix/promo fails to create (brave-intl#2616) * Handles rare scenario where promo server doesn't create a promo registration * Update puma. Update offline aka local scenario * Move Invoice to feature flag (brave-intl#2612) * Update count of content creator accounts to 500,000 (brave-intl#2603) * Better lookup of invoices (brave-intl#2618) * Update publishers_status_updates API Return the status_update ID in the response upon sucessfull API call * Remove unused gems. Remove possible unused initializer (brave-intl#2630) * Remove unused gems. Remove possible unused initializer * We're hitting the API limit on youtube. Closes #2636. (brave-intl#2637) * We're hitting the API limit on youtube. Closes #2636. * Only store stats against half the users * Fix CSS for out-of-place copy button (brave-intl#2628) * Fix CSS for out-of-place copy button * Eliminate erroneous devise flash messages. Closes #2620 (brave-intl#2625) * Eliminate erroneous devise flash messages. Closes #2620 * Updated comments for future review * Use follower database for reads on certain queries (brave-intl#2503) * Use follower database for reads on certain queries * Fix config * Optionally run rake db:setup * Disable automatic switching since GET requests sometimes saves stuff like UserAuthenticationTokens * Enable peer to peer for everyone (brave-intl#2640) * Redirect to production for staging * Initial testing commit * Larger channels list on staging * Specify fake channels for testing * Fix #2643 * Update cache_browser_channels_json_job_v3.rb * Fix readonly setup (brave-intl#2649) * Change tos link * Create snapshots (brave-intl#2648) * Create snapshots * Get it to pass stub tests with EAFP since they aren't relevant * Added simple TOS flow * Updated CSS * Include payout_report_id as param for post (brave-intl#2653) * Add a slash * Add content-type to header * Caps referral amounts for P2P and feature-flagged creators (brave-intl#2624) Closes #2596 * Decrease the number of pings we use for site channel verifications. * V3 channels with pagination * Support status 204 * Fix array substring for V3 API * Include cap for peer-to-peer * Resolve 2FA Issue (brave-intl#2670) * Case System improvements (brave-intl#2627) * General Case System improvements * Remove Organizations from the sidebar * Cases status update * Add index * Alberts great suggestion * Add more clarity to Statements (brave-intl#2638) * Add more clarity to Statements * Add comment describing fees * Format date on front end * Limit the length of a name (brave-intl#2671) * Limit the length of a name * Downcase the pending email * Change when jobs get enqueued (brave-intl#2676) * Temporary patch on rate limits * Syncs late at night to prevent API limit hits * Fix JS Vulnerabilities (brave-intl#2677) * Bugfix/rate limit (brave-intl#2675) * Fix youtube rate limit * No longer need to store channel stats * remove from sidekiq * Fix admin payment page (brave-intl#2678) * Fix manual payout report job (brave-intl#2683) * Cache Uphold Tips (brave-intl#2682) * Remove requests to prevent excess data use (brave-intl#2689) * Remove requests to prevent excess data use * Eliminate rack-attack limits for public API. We protect against thundering herd by limiting the number of requests that can try to access publishers (brave-intl#2693) * Fix Statement Bugs (brave-intl#2690) * Have warning for the quota (brave-intl#2692) * Rails gem update (brave-intl#2699) * Rack attack update * Updated assets * Upgrade to ruby 2.7.1 (brave-intl#2664) * Upgrade to ruby 2.7.1 * Support changes to BigDecimal * Updated dependencies * Use URI.encode_www_form_component instead of URI.escape since it's now deprecated * Add unique index for Uphold Transaction ID (brave-intl#2701) * Upgrade Twitch Gem (brave-intl#2702) * Backfill Publisher Statuses (brave-intl#2703) * Create Merchant Feature (brave-intl#2622) * Upgrade rails to 6.0.3.1 (brave-intl#2712) * Upgrade rails to 6.0.3.1 * Upgade yarn package * Close the connection after setnx is called. Related to redis/redis-rb#524 (brave-intl#2711) * Fix compilation issues (brave-intl#2714) * Fix compilation issues * Update jest-styled-components * Fix symbol underscore bug (brave-intl#2716) * Bump puma from 4.3.4 to 4.3.5 (brave-intl#2718) Bumps [puma](https://github.com/puma/puma) from 4.3.4 to 4.3.5. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](https://github.com/puma/puma/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified typos in Japanese translation %{brave_publisher_id} wasn't expanded. @yachtcaptain23 Could you please check the line 853? * Add quotes * Don't ping promo so much (brave-intl#2721) * Speed up site banner lookup * Don't use full table scan against different tables. This might not be the conclusive fix though since search test still needs to be done. (brave-intl#2725) * Fix perf issue when looking up contested_by_channel_id (brave-intl#2724) * DB improvements for pagination without needing full table scan (brave-intl#2728) * Feature: V4 Channels prefix list. Major performance improvements focus (brave-intl#2697) * Feature: V4 Channels prefix list. Major performance improvements focus for both server side costs and client side computation. * Use new version of S3 privacy preserving asset serving. * Fix the URL used. Fix the rake task for v4 to use all channels. (brave-intl#2734) * Change http to https on meta og:url tag (brave-intl#2735) * Download on campaign for unattached promos (brave-intl#2736) * Download on campaign for unattached promos * Fixed naming scheme to be more RESTful (brave-intl#2737) * Bump websocket-extensions from 0.1.4 to 0.1.5 (brave-intl#2738) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-ruby) from 0.1.4 to 0.1.5. - [Release notes](https://github.com/faye/websocket-extensions-ruby/releases) - [Changelog](https://github.com/faye/websocket-extensions-ruby/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-ruby@0.1.4...0.1.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump websocket-extensions in /public/creators-landing Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> * Bump websocket-extensions from 0.1.3 to 0.1.4 (brave-intl#2740) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix .rubocop.yml Warnings (brave-intl#2739) * Fix lookup of which channels get included in the prefix list * Lock down gem versions (brave-intl#2744) * Require KYC to enroll in promo registrations (brave-intl#2733) * Remove library not used in production (brave-intl#2752) * Include channels with no uphold verification connection to be enqueued in Cache::BrowserChannels::Main. * Add mock data for staging environment (brave-intl#2760) * Add mock data for staging environment * Update gem * Update app/jobs/cache/browser_channels/prefix_list.rb Co-authored-by: Cory McDonald <cmcdonald@brave.com> Co-authored-by: Cory McDonald <cmcdonald@brave.com> * Upgrade Rails to 6.0.3.2 (brave-intl#2762) * Refactor/renaming publisher prefix list (brave-intl#2764) Rename PublisherList to PublisherPrefixList * Use the 1-hop Fastly & rewards bucket for hosting rather than using 2 hops. (brave-intl#2766) * Wallet state expanded (brave-intl#2771) * Refactor to load wallet state at generation time * Closes #2773 * Remove unused column (brave-intl#2776) * Add check for deleted cards (brave-intl#2763) Co-authored-by: Albert Wang <amwang217@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chkk525 <r.chikaki@gmail.com> Co-authored-by: Jacob Lamont <cob@jacoblamont.com> Co-authored-by: Jacob Lamont <jlamont@brave.com> Co-authored-by: Nick von Pentz <nickvonpentz@gmail.com> commit 45d00ea Merge: 662605c 63c93f8 Author: Cory McDonald <cory@corywmcdonald.com> Date: Tue Dec 3 10:37:31 2019 -0600 Merge pull request #1 from brave-intl/staging t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.