Production Release 2024-04-26 #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than being dumped in the root directory, which is unusual.
github-actions
bot
changed the title
Use `@/name` for app imports, as opposed to just `name` as previously. This is the modern convention for web apps, and makes clearer when imports are coming from the application as opposed to npm modules. There's a few deep `../../` style imports remaining - these get worse if I move them to `@/`-style imports, and I think are better left until we move the files around a bit more in a subsequent PR.
We rely instead on packaged versions from @fontsource as has been the case for a long time. These are not used.
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | Pending | |---|---|---|---|---|---|---|---|---| | [@mui/x-data-grid](https://mui.com/x/react-data-grid/) ([source](https://togithub.com/mui/mui-x/tree/HEAD/packages/x-data-grid)) | [`7.2.0` -> `7.3.0`](https://renovatebot.com/diffs/npm/@mui%2fx-data-grid/7.2.0/7.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.78` -> `18.2.79`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.78/18.2.79) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`7.6.0` -> `7.7.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/7.6.0/7.7.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | `7.7.1` | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`7.6.0` -> `7.7.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/7.6.0/7.7.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | `7.7.1` | | [actions/checkout](https://togithub.com/actions/checkout) | `v4.1.1` -> `v4.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | patch | | | [github/codeql-action](https://togithub.com/github/codeql-action) | `v3.24.10` -> `v3.25.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | minor | `v3.25.2` | | [vite](https://vitejs.dev) ([source](https://togithub.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.2.8` -> `5.2.10`](https://renovatebot.com/diffs/npm/vite/5.2.8/5.2.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | --- ### Release Notes <details> <summary>mui/mui-x (@​mui/x-data-grid)</summary> ### [`v7.3.0`](https://togithub.com/mui/mui-x/blob/HEAD/CHANGELOG.md#730) [Compare Source](https://togithub.com/mui/mui-x/compare/v7.2.0...v7.3.0) *Apr 18, 2024* We'd like to offer a big thanks to the 10 contributors who made this release possible. Here are some highlights ✨: - 📄 Support [unknown and estimated row count in server-side pagination](https://mui.com/x/react-data-grid/pagination/#index-based-pagination) ([#​12490](https://togithub.com/mui/mui-x/issues/12490)) [@​MBilalShafi](https://togithub.com/MBilalShafi) - 🎨 Support color scales in Charts ([#​12490](https://togithub.com/mui/mui-x/issues/12490)) [@​alexfauquette](https://togithub.com/alexfauquette) Add a [`colorMap` configuration](https://mui.com/x/react-charts/styling/#values-color) to an axis, and the chart will use it to select colors. Each impacted chart ([bar charts](https://mui.com/x/react-charts/bars/#color-scale), [line charts](https://mui.com/x/react-charts/lines/#color-scale), [scatter charts](https://mui.com/x/react-charts/scatter/#color-scale)) has a dedicated section explaining how this color map is impacting it. <img src="https://github.com/mui/mui-x/assets/45398769/f0066606-3486-4c4e-b3be-7fdd56d763c3" alt="scatter chart with gradient along y-axis" /> - 🌍 Improve Danish (da-DK) locale on the Data Grid - 🐞 Bugfixes - 📚 Documentation improvements ##### Data Grid ##### `@mui/x-data-grid@7.3.0` - \[DataGrid] Fix calling `onCellEditStop` on error ([#​12747](https://togithub.com/mui/mui-x/issues/12747)) [@​sai6855](https://togithub.com/sai6855) - \[DataGrid] Fix column resize ([#​12792](https://togithub.com/mui/mui-x/issues/12792)) [@​romgrk](https://togithub.com/romgrk) - \[DataGrid] Fix column separators ([#​12808](https://togithub.com/mui/mui-x/issues/12808)) [@​romgrk](https://togithub.com/romgrk) - \[DataGrid] Limit panel width to not exceed screen width ([#​12799](https://togithub.com/mui/mui-x/issues/12799)) [@​cherniavskii](https://togithub.com/cherniavskii) - \[DataGrid] Support advanced server-side pagination use cases ([#​12474](https://togithub.com/mui/mui-x/issues/12474)) [@​MBilalShafi](https://togithub.com/MBilalShafi) - \[DataGrid] Support state export and restore on grid density ([#​12671](https://togithub.com/mui/mui-x/issues/12671)) [@​MBilalShafi](https://togithub.com/MBilalShafi) - \[l10n] Improve Danish (da-DK) locale ([#​12784](https://togithub.com/mui/mui-x/issues/12784)) [@​EmilBahnsen](https://togithub.com/EmilBahnsen) ##### `@mui/x-data-grid-pro@7.3.0` [](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-data-grid@7.3.0`, plus: - \[DataGridPro] Implement header filter height ([#​12666](https://togithub.com/mui/mui-x/issues/12666)) [@​romgrk](https://togithub.com/romgrk) ##### `@mui/x-data-grid-premium@7.3.0` [](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-data-grid-pro@7.3.0`. ##### Charts ##### Breaking change A typo fix: ```diff - ContinuouseScaleName + ContinuousScaleName ``` ##### `@mui/x-charts@7.3.0` - \[charts] Add `dataIndex` to series `valueFormatter` ([#​12745](https://togithub.com/mui/mui-x/issues/12745)) [@​JCQuintas](https://togithub.com/JCQuintas) - \[charts] Add color scale ([#​12490](https://togithub.com/mui/mui-x/issues/12490)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[charts] Do not document the usage of `DEFAULT_X_AXIS_KEY` and `DEFAULT_Y_AXIS_KEY` ([#​12780](https://togithub.com/mui/mui-x/issues/12780)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[charts] Export more utils ([#​12744](https://togithub.com/mui/mui-x/issues/12744)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[charts] Fix passing slot props down to `PieArcLabel` ([#​12806](https://togithub.com/mui/mui-x/issues/12806)) [@​JCQuintas](https://togithub.com/JCQuintas) ##### Tree View ##### `@mui/x-tree-view@7.3.0` - \[TreeView] Support `defaultMuiPrevented` on the `onFocus` prop of the root slot ([#​12813](https://togithub.com/mui/mui-x/issues/12813)) [@​flaviendelangle](https://togithub.com/flaviendelangle) ##### Docs - \[docs] Add grid cell display example to the migration guide ([#​12793](https://togithub.com/mui/mui-x/issues/12793)) [@​romgrk](https://togithub.com/romgrk) - \[docs] Use charts classes objects ([#​12781](https://togithub.com/mui/mui-x/issues/12781)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[docs] Fix layout shift on demos ([#​12816](https://togithub.com/mui/mui-x/issues/12816)) [@​zanivan](https://togithub.com/zanivan) - \[test] Increase timeout for test that sometimes fail on `DateTimeRangePicker` ([#​12786](https://togithub.com/mui/mui-x/issues/12786)) [@​LukasTy](https://togithub.com/LukasTy) ##### Core - \[docs-infra] Prepare infra to document charts interfaces ([#​12653](https://togithub.com/mui/mui-x/issues/12653)) [@​alexfauquette](https://togithub.com/alexfauquette) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v7.7.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#770-2024-04-15) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.6.0...v7.7.0) ##### 🚀 Features - **eslint-plugin:** replace `no-new-symbol` with `no-new-native-nonconstructor` ##### ❤️ Thank You - Dave - Josh Goldberg ✨ You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v7.7.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#770-2024-04-15) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.6.0...v7.7.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.3`](https://togithub.com/actions/checkout/releases/tag/v4.1.3) [Compare Source](https://togithub.com/actions/checkout/compare/v4.1.2...v4.1.3) #### What's Changed - Update `actions/checkout` version in `update-main-version.yml` by [@​jww3](https://togithub.com/jww3) in [actions/checkout#1650 - Check git version before attempting to disable `sparse-checkout` by [@​jww3](https://togithub.com/jww3) in [actions/checkout#1656 - Add SSH user parameter by [@​cory-miller](https://togithub.com/cory-miller) in [actions/checkout#1685 **Full Changelog**: actions/checkout@v4.1.2...v4.1.3 ### [`v4.1.2`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v412) [Compare Source](https://togithub.com/actions/checkout/compare/v4.1.1...v4.1.2) - Fix: Disable sparse checkout whenever `sparse-checkout` option is not present [@​dscho](https://togithub.com/dscho) in [actions/checkout#1598 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.25.1`](https://togithub.com/github/codeql-action/compare/v3.25.0...v3.25.1) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.25.0...v3.25.1) ### [`v3.25.0`](https://togithub.com/github/codeql-action/compare/v3.24.10...v3.25.0) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.24.10...v3.25.0) </details> <details> <summary>vitejs/vite (vite)</summary> ### [`v5.2.10`](https://togithub.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small5210-2024-04-20-small) [Compare Source](https://togithub.com/vitejs/vite/compare/v5.2.9...v5.2.10) - revert: perf: use workspace root for fs cache ([#​15712](https://togithub.com/vitejs/vite/issues/15712)) ([#​16476](https://togithub.com/vitejs/vite/issues/16476)) ([77e7359](https://togithub.com/vitejs/vite/commit/77e7359)), closes [#​15712](https://togithub.com/vitejs/vite/issues/15712) [#​16476](https://togithub.com/vitejs/vite/issues/16476) - fix: add base to virtual html ([#​16442](https://togithub.com/vitejs/vite/issues/16442)) ([721f94d](https://togithub.com/vitejs/vite/commit/721f94d)), closes [#​16442](https://togithub.com/vitejs/vite/issues/16442) - fix: adjust esm syntax judgment logic ([#​16436](https://togithub.com/vitejs/vite/issues/16436)) ([af72eab](https://togithub.com/vitejs/vite/commit/af72eab)), closes [#​16436](https://togithub.com/vitejs/vite/issues/16436) - fix: don't add outDirs to watch.ignored if emptyOutDir is false ([#​16453](https://togithub.com/vitejs/vite/issues/16453)) ([6a127d6](https://togithub.com/vitejs/vite/commit/6a127d6)), closes [#​16453](https://togithub.com/vitejs/vite/issues/16453) - fix(cspNonce): don't overwrite existing nonce values ([#​16415](https://togithub.com/vitejs/vite/issues/16415)) ([b872635](https://togithub.com/vitejs/vite/commit/b872635)), closes [#​16415](https://togithub.com/vitejs/vite/issues/16415) - feat: show warning if root is in build.outDir ([#​16454](https://togithub.com/vitejs/vite/issues/16454)) ([11444dc](https://togithub.com/vitejs/vite/commit/11444dc)), closes [#​16454](https://togithub.com/vitejs/vite/issues/16454) - feat: write cspNonce to style tags ([#​16419](https://togithub.com/vitejs/vite/issues/16419)) ([8e54bbd](https://togithub.com/vitejs/vite/commit/8e54bbd)), closes [#​16419](https://togithub.com/vitejs/vite/issues/16419) - chore(deps): update dependency eslint-plugin-n to v17 ([#​16381](https://togithub.com/vitejs/vite/issues/16381)) ([6cccef7](https://togithub.com/vitejs/vite/commit/6cccef7)), closes [#​16381](https://togithub.com/vitejs/vite/issues/16381) ### [`v5.2.9`](https://togithub.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small529-2024-04-15-small) [Compare Source](https://togithub.com/vitejs/vite/compare/v5.2.8...v5.2.9) - fix: `fsp.rm` removing files does not take effect ([#​16032](https://togithub.com/vitejs/vite/issues/16032)) ([b05c405](https://togithub.com/vitejs/vite/commit/b05c405)), closes [#​16032](https://togithub.com/vitejs/vite/issues/16032) - fix: fix accumulated stacks in error overlay ([#​16393](https://togithub.com/vitejs/vite/issues/16393)) ([102c2fd](https://togithub.com/vitejs/vite/commit/102c2fd)), closes [#​16393](https://togithub.com/vitejs/vite/issues/16393) - fix(deps): update all non-major dependencies ([#​16376](https://togithub.com/vitejs/vite/issues/16376)) ([58a2938](https://togithub.com/vitejs/vite/commit/58a2938)), closes [#​16376](https://togithub.com/vitejs/vite/issues/16376) - chore: update region comment ([#​16380](https://togithub.com/vitejs/vite/issues/16380)) ([77562c3](https://togithub.com/vitejs/vite/commit/77562c3)), closes [#​16380](https://togithub.com/vitejs/vite/issues/16380) - perf: reduce size of injected \__vite\_\_mapDeps code ([#​16184](https://togithub.com/vitejs/vite/issues/16184)) ([c0ec6be](https://togithub.com/vitejs/vite/commit/c0ec6be)), closes [#​16184](https://togithub.com/vitejs/vite/issues/16184) - perf(css): only replace empty chunk if imported ([#​16349](https://togithub.com/vitejs/vite/issues/16349)) ([e2658ad](https://togithub.com/vitejs/vite/commit/e2658ad)), closes [#​16349](https://togithub.com/vitejs/vite/issues/16349) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/brave/ads-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-actions
bot
changed the title
As we use on other internal projects, use the client-preset for codegen. This means we can more easily: - make use of other apollo operations like `useSuspenseQuery` - migrate code from internal codebases to here - in due course, move towards co-locating queries with their components, and [using fragment hiding](https://the-guild.dev/blog/unleash-the-power-of-fragments-with-graphql-codegen) to better track what needs to be queried I've tried to be mechanical about the changes here, limiting changes to just what was needed.
The new version of data grid stopped cells automatically being display: "flex" for layout performance reasons. Enforce this for those cells that need it. Before: <img width="1211" alt="Screenshot 2024-04-24 at 15 01 19" src="https://github.com/brave/ads-ui/assets/51444/e19b47ba-dac1-4982-b788-7cda178c5b34"> After: <img width="1211" alt="Screenshot 2024-04-24 at 15 02 50" src="https://github.com/brave/ads-ui/assets/51444/65e1f872-287b-42bb-8a61-ec9054da5610"> Before: <img width="1061" alt="Screenshot 2024-04-24 at 15 40 07" src="https://github.com/brave/ads-ui/assets/51444/86665b29-e165-4e94-b307-dfb71bb39de1"> After: <img width="1061" alt="Screenshot 2024-04-24 at 15 38 29" src="https://github.com/brave/ads-ui/assets/51444/b78ce51f-bf63-4ab2-a667-6fc8950cbae3">
IanKrieger
approved these changes
Apr 25, 2024
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Chores
Refactors
@/for in-app imports #1170