Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust wording on campaign type selection screen #1196

Merged
merged 1 commit into from
May 23, 2024

Conversation

tackley
Copy link
Collaborator

@tackley tackley commented May 22, 2024

None of our ad formats are sub-premium, so this wording is misleading.

Screenshot 2024-05-22 at 12 04 22

None of our ad formats are sub-premium, so this wording is misleading.
@tackley tackley requested a review from a team as a code owner May 22, 2024 11:05
Copy link

[puLL-Merge] - brave/ads-ui@1196

Here is my review of the PR:

Description

This PR makes a few minor text changes in the localization files and validation schema. It changes some instances of "premium ad placements" to "New Tab Takeover campaigns". A few validation rules around audience targeting and location fields were removed or commented out.

Changes

Changes

auth/registration/AccountChoice.tsx

  • Changed "premium ad placements" to "New Tab Takeover campaigns" in the contact us link text

locales/en.po, es.po, pt.po, test.po

  • Updated translations for the "New Tab Takeover campaigns" text change
  • Removed translations for a few validation messages that were removed

validation/CampaignSchema.tsx

  • Removed "At least one audience must be targeted" validation
  • Commented out the "Location" field and its description text
  • Adjusted line numbers for other validations due to removed lines

user/campaignList/CampaignList.tsx
user/views/user/search/SetupProgress.tsx
user/ads/AdsExistingAd.tsx

  • Line number changes only due to changes in other files

components/Creatives/SearchPreview.tsx

  • Line number change on "Sponsored" text, likely due to unrelated changes in this file

Overall this PR focuses on changing the wording around premium ad placements and removes a couple targeting related validations. The changes look straightforward and low-risk.

@tackley tackley merged commit 6a2ed83 into master May 23, 2024
8 checks passed
@tackley tackley deleted the feat/use-ntt-not-premium branch May 23, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants