Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement changes to support sync v2 on Android #10203

Closed
AlexeyBarabash opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5361
Closed

[Android] Implement changes to support sync v2 on Android #10203

AlexeyBarabash opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5361

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Implement changes to support sync v2 on Android

@AlexeyBarabash AlexeyBarabash added feature/sync OS/Android Fixes related to Android browser functionality labels Jun 10, 2020
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 10, 2020
@AlexeyBarabash AlexeyBarabash added this to Untriaged backlog in Sync via automation Jun 10, 2020
Sync automation moved this from Untriaged backlog to Completed Jun 29, 2020
@AlexeyBarabash AlexeyBarabash added this to the 1.12.x - Beta milestone Jul 23, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2020

Verification passed on OnePlus 6T with Android 10 running 1.12.108

Migrating from sync v1

  • Verified sync is disabled after migration
  • Verified infobar is shown on upgrade to 1.12.x and infobar contains Begin Setup which when clicked loads sync creation page

Sync chain creation on Android and connect desktop

  • Verified creating sync chain on Android and adding desktop to the chain works fine
  • Verified both devices list each other
Android Desktop
image image
  • Verified bookmarks added on Android is sync'd on desktop and bookmarks added on desktop sync's to Android

Sync chain created on Desktop and connect Android

  • Verified able to join a sync chain created on Desktop by entering code words from desktop
  • Verified both devices list each other
  • Verified bookmarks added on Desktop sync's to Android and bookmarks added on Android sync's to Desktop

Connect to the chain through QR code

  • Verified able to join a sync chain created on Desktop by scanning the QR code
  • Verified both devices list each other
  • Verified bookmarks added on Desktop sync's to Android and bookmarks added on Android sync's to Desktop

Connect to the chain through QR code

  • Verified able to join a sync chain created on Device A by scanning the QR code
  • Verified both devices list each other
  • Verified bookmarks added on Device A sync's to Device B and bookmarks added on Device B sync's to Device A

Leave and re-connect to the chain

  • Verified joining a sync chain and leaving it removes the device list
  • Verified rejoining the same sync chain just shows the active devices on the list

Autofill Sync

  • Verified adding/editing/deleting autofill works fine and sync's across devices

Bookmark Sync

  • Verified adding/editing/reordering/deleting bookmarks works fine and sync's across devices

History Sync

  • Verified visiting pages and adding history is sync'd across devices
  • Verified deleting a single history entry is sync'd across devices
  • Verified clearing browser data remove history entries across all devices

Open Tabs

  • Verified sending open tabs from desktop sends a notification on mobile device
Notification tray Notificaton on app
image image
  • Verified sent tab is automatically added in history

Password Sync

  • Verified saved passwords are sync'd successfully between devices
  • Verified deleting stored password updates and removes it from all the devices on sync chain

Settings Sync

  • Verified settings are sync'd across devices correctly

Verification passed on Samsung Tab A with Android 10 running 1.12.108

Migrating from sync v1

  • Verified sync is disabled after migration
  • Verified infobar is shown on upgrade to 1.12.x and infobar contains Begin Setup which when clicked loads sync creation page

Sync chain creation on Android and connect desktop

  • Verified creating sync chain on Android and adding desktop to the chain works fine
  • Verified both devices list each other
Android Desktop
image image
  • Verified bookmarks added on Android is sync'd on desktop and bookmarks added on desktop sync's to Android

Sync chain created on Desktop and connect Android

  • Verified able to join a sync chain created on Desktop by entering code words from desktop
  • Verified both devices list each other
  • Verified bookmarks added on Desktop sync's to Android and bookmarks added on Android sync's to Desktop

Connect to the chain through QR code

  • Verified able to join a sync chain created on Desktop by scanning the QR code
  • Verified both devices list each other
  • Verified bookmarks added on Desktop sync's to Android and bookmarks added on Android sync's to Desktop

Connect to the chain through QR code

  • Verified able to join a sync chain created on Device A by scanning the QR code
  • Verified both devices list each other
  • Verified bookmarks added on Device A sync's to Device B and bookmarks added on Device B sync's to Device A

Leave and re-connect to the chain

  • Verified joining a sync chain and leaving it removes the device list
  • Verified rejoining the same sync chain just shows the active devices on the list

Autofill Sync

  • Verified adding/editing/deleting autofill works fine and sync's across devices

Bookmark Sync

  • Verified adding/editing/reordering/deleting bookmarks works fine and sync's across devices

History Sync

  • Verified visiting pages and adding history is sync'd across devices
  • Verified deleting a single history entry is sync'd across devices
  • Verified clearing browser data remove history entries across all devices

Open Tabs

  • Verified sending open tabs from desktop sends a notification on mobile device
Notification tray Notificaton on app
image image
  • Verified sent tab is automatically added in history

Password Sync

  • Verified saved passwords are sync'd successfully between devices
  • Verified deleting stored password updates and removes it from all the devices on sync chain

Settings Sync

  • Verified settings are sync'd across devices correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Sync
  
Completed
Development

Successfully merging a pull request may close this issue.

2 participants