Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Do not clear url bar text on focus #10524

Closed
samartnik opened this issue Jun 30, 2020 · 5 comments · Fixed by brave/brave-core#5978
Closed

[Android] Do not clear url bar text on focus #10524

samartnik opened this issue Jun 30, 2020 · 5 comments · Fixed by brave/brave-core#5978
Assignees
@samartnik
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Android Core 1.12
Milestone
1.12.x - Release #1

Comments

@samartnik
Copy link
Contributor

samartnik commented Jun 30, 2020 •
edited
Loading

Description

As per discussion https://bravesoftware.slack.com/archives/C20HMJ62H/p1592687065037300
Do not clear url bar text on focus.

Steps to reproduce

  1. Go to any website
  2. Click on url bar
  3. Url itself is disappeared
    device-2020-06-30-133103

Actual result

Url itself is disappeared

Expected result

Url is shown and highlighted

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.10.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Jun 30, 2020
@samartnik samartnik self-assigned this Jun 30, 2020
@samartnik
Copy link
Contributor Author

samartnik commented Jun 30, 2020 •
edited
Loading

Test plan:

  1. Go to any website
  2. Click on url bar
  3. Url should be shown and highlighted

@samartnik
Copy link
Contributor Author

After change
device-2020-06-30-133048

@samartnik samartnik mentioned this issue Jun 30, 2020
Merged
32 tasks
@samartnik
Copy link
Contributor Author

@jumde could you confirm if this behavior is ok or not brave/brave-core#5978 (comment)

@anthonypkeane anthonypkeane added this to In Progress in Android Core 1.11 Jul 8, 2020
@anthonypkeane anthonypkeane removed this from In Progress in Android Core 1.11 Jul 8, 2020
@anthonypkeane anthonypkeane added this to In Progress in Android Core 1.12 Jul 8, 2020
@jumde
Copy link
Contributor

jumde commented Jul 8, 2020

@samartnik - comment here: brave/brave-core#5978 (comment)

@brave-builds brave-builds mentioned this issue Jul 9, 2020
Merged
4 tasks
@kjozwiak kjozwiak added this to the 1.12.x - Beta milestone Jul 14, 2020
@anthonypkeane anthonypkeane moved this from In Progress to Closed in Android Core 1.12 Jul 29, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2020 •
edited by LaurenWags
Loading

Verification passed on OnePlus 6T with Android 10 running 1.12.106 x64 beta build

Verification passed on Samsung Tab A with Android 10 running 1.12.106 x64 beta build

Verification passed on Asus Zenfone (x86) with Android 6 running 1.12.112 BraveModernx86.apk

This was referenced Aug 11, 2020
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
@samartnik samartnik mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
No open projects
Android Core 1.12
Closed
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Do not clear url bar text on focus brave/brave-core
5 participants
@jumde @kjozwiak @srirambv @LaurenWags @samartnik