Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10565

Closed
byyxx128 opened this issue Jul 5, 2020 · 5 comments
Closed

#10565

byyxx128 opened this issue Jul 5, 2020 · 5 comments
Labels
closed/works-for-me design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@byyxx128
Copy link

byyxx128 commented Jul 5, 2020

@rebron
Copy link
Collaborator

rebron commented Aug 21, 2020

If you clear Sites and Shields settings here -> brave://settings/clearBrowserData which will clear all the custom shields settings you did, you can then go to brave://settings/shields and disable "Trackers and Ads blocking".
Does that work for you and can you try in our latest 1.12.114 release?

@rebron rebron added feature/settings needs-more-info The report requires more detail before we can decide what to do with this issue. feature/global-settings Settings at browser level independent of shields settings design A design change, especially one which needs input from the design team labels Aug 21, 2020
@rebron rebron added this to Untriaged backlog in Settings Aug 25, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 31, 2020
@rebron
Copy link
Collaborator

rebron commented Aug 31, 2020

cc: @Brave-Matt Are we seeing additional reports of Brave Shields settings not sticking?

@rebron rebron moved this from Untriaged backlog to P3 backlog in Settings Aug 31, 2020
@rebron rebron added this to Untriaged Backlog in General Sep 1, 2020
@rebron rebron moved this from Untriaged Backlog to P3 Backlog in General Sep 1, 2020
@mredigonda
Copy link

I'm experiencing this problem too in Brave Version 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit). I try to set "Trackers & ads blocking" to disabled but after restart of the browser that setting gets back to default "standard".

@bsclifton
Copy link
Member

Closing as this issue (as it's captured); it works as expected (testing on 1.19.92)

If you have touched the shield settings though (clicked to turn off shields on a site, etc) the global settings will be overridden by the local site setting (which is expected behavior).

The following issues capture problems that are actionable:

General automation moved this from P3 Backlog to Completed Feb 8, 2021
@bsclifton bsclifton added closed/works-for-me and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 8, 2021
@bsclifton bsclifton removed this from P3 backlog in Settings Feb 8, 2021
@bsclifton bsclifton removed this from Completed in General Feb 8, 2021
@byyxx128 byyxx128 changed the title [Desktop] Brave Shields cannot be disabled through “brave://settings/shields” Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants