Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync v2] FCM invalidation integration #11118

Open
darkdh opened this issue Aug 6, 2020 · 1 comment
Open

[Sync v2] FCM invalidation integration #11118

darkdh opened this issue Aug 6, 2020 · 1 comment
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@darkdh
Copy link
Member

darkdh commented Aug 6, 2020

https://chromium.googlesource.com/chromium/src/+/master/components/invalidation/impl/README.md

We currently replies on periodic polling (60s), that will have many meaning sync cycles and also causing issue like #11116

Client need to get FCM related config setup so it can register itself to FCM server with interested topics(Sync Types)
Server will receive instance ID(invalidator_client_id) from client in sync.proto and it need to send notification to FCM server with instance IDs if some sync types have new data or when first time setup.
And then Client will only receive notification of enabled sync types from FCM server.
When receiving it, client will do a poll and nudge for the types in notification.

@darkdh darkdh added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 6, 2020
@jsecretan jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Aug 25, 2020
@shadow1349
Copy link

I'm not sure why, but blocking FCM has also broken Firebase Callable Functions in Angular. Here's a comment I made for it:

angular/angularfire#2475 (comment)

I don't think there is much the Angular team can do to fix it since it seems the issue is on Brave itself. Now my whole app is broken in Brave since I rely on callable functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P3, P4, & P5 backlog
Development

No branches or pull requests

3 participants