Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brave Ads page classification scores from locally persisted diagnostic log #11220

Closed
tmancey opened this issue Aug 13, 2020 · 1 comment · Fixed by brave/brave-core#6420

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 13, 2020

No description provided.

@tmancey tmancey self-assigned this Aug 13, 2020
@tmancey tmancey added this to New issues in Ads via automation Aug 13, 2020
@tmancey tmancey moved this from New issues to Review in Ads Aug 13, 2020
Ads automation moved this from Review to Done Aug 14, 2020
@tmancey tmancey added this to the 1.14.x - Nightly milestone Aug 14, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2020

Verification passed on


Brave | 1.14.66 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

[18372:7824:0828/173857.508:VERBOSE1:page_classifier.cc(86)] Classified page as technology & computing-software
[18372:7824:0828/173857.508:VERBOSE1:page_classifier.cc(94)] Winning page classification over time is technology & computing-software
  • Verified viewing an ad the event is logged in the diagnostic log
[18372:7824:0828/173933.573:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 2e2e6b7f-8470-48d0-8684-d141caacc920 and 850caa74-2cb6-4ea2-b0cf-11031cc157ce creative instance id
[18372:7824:0828/173933.573:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 850caa74-2cb6-4ea2-b0cf-11031cc157ce
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: IN
  confirmationType: view
  • Verified clicking an ad the event is logged in the diagnostic log
[18372:7824:0828/173935.820:VERBOSE3:ad_notification_event_clicked.cc(32)] Clicked ad notification with uuid 2e2e6b7f-8470-48d0-8684-d141caacc920 and 850caa74-2cb6-4ea2-b0cf-11031cc157ce creative instance id
[18372:7824:0828/173935.821:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 850caa74-2cb6-4ea2-b0cf-11031cc157ce
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: IN
  confirmationType: click
  • Verified dismissing an ad the event is logged in the diagnostic log
[1548:12272:0828/174907.931:VERBOSE3:ad_notification_event_dismissed.cc(32)] Dismissed ad notification with uuid f5574f81-a3e6-4b8b-a4ae-66def285e7d4 and 9a63c755-4525-4599-a6fa-96cd64bb7f91 creative instance id
[1548:12272:0828/174907.931:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 9a63c755-4525-4599-a6fa-96cd64bb7f91
  creativeSetId: f706af3a-4cb9-4e85-bf6d-6259bd696d4e
  category: food & drink
  targetUrl: https://travala.com/
  geoTarget: IN
  confirmationType: dismiss
  • After getting an Ad, ad got auto dismissed and Timed out event got captured in the diagnostic logs
[11920:3136:0828/175314.022:VERBOSE3:ad_notification_event_timed_out.cc(26)] Timed out ad notification with uuid 83d6c44e-a00f-4193-abac-a538afe6b35c and f66023a4-3150-4251-bff2-d0486b8c0959 creative instance id

Verification passed on

Brave 1.14.68 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS
[7326:7326:0901/173931.799957:VERBOSE1:page_classifier.cc(86)] Classified page as technology & computing-software
[7326:7326:0901/173931.800027:VERBOSE1:page_classifier.cc(94)] Winning page classification over time is technology & computing-software
  • Verified viewing an ad the event is logged in the diagnostic log
[7817:7817:0901/174254.634900:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 7d04db29-b02c-4126-ba8e-65ac4fe61243
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view
  • Verified clicking an ad the event is logged in the diagnostic log
[7817:7817:0901/174259.957060:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 7d04db29-b02c-4126-ba8e-65ac4fe61243
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: click
  • Verified landed an ad the event is logged in the diagnostic log
[7817:7817:0901/174332.620746:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 7d04db29-b02c-4126-ba8e-65ac4fe61243
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: landed
  • After getting an Ad, ad got auto dismissed and Timed out event got captured in the diagnostic logs
[8325:8325:0901/175014.072908:VERBOSE3:ad_notification_event_timed_out.cc(26)] Timed out ad notification with uuid 6d6499a9-65d0-4069-968e-1ae7d21a8581 and 307a7ac4-29f1-483e-9257-ce033e3b5e51 creative instance id


Verified passed with

Brave | 1.14.72 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)
[9608:775:0902/091125.587979:VERBOSE1:page_classifier.cc(86)] Classified page as technology & computing-software
[9608:775:0902/091125.588046:VERBOSE1:page_classifier.cc(94)] Winning page classification over time is technology & computing-software
[9608:775:0902/091125.588922:VERBOSE1:ad_conversions.cc(155)] No ad conversion matches found for visited URL
  • Confirmed view event is logged in the diagnostic log
[9608:775:0902/091218.948814:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid f0bec81f-875b-4460-93a9-487d85d3f35d and 307a7ac4-29f1-483e-9257-ce033e3b5e51 creative instance id
[9608:775:0902/091218.948949:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 307a7ac4-29f1-483e-9257-ce033e3b5e51
  creativeSetId: f706af3a-4cb9-4e85-bf6d-6259bd696d4e
  category: food & drink
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view
  • Confirmed click event is logged in the diagnostic log
[9608:775:0902/091300.648053:VERBOSE3:ad_notification_event_clicked.cc(32)] Clicked ad notification with uuid f0bec81f-875b-4460-93a9-487d85d3f35d and 307a7ac4-29f1-483e-9257-ce033e3b5e51 creative instance id
[9608:775:0902/091300.649666:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 307a7ac4-29f1-483e-9257-ce033e3b5e51
  creativeSetId: f706af3a-4cb9-4e85-bf6d-6259bd696d4e
  category: food & drink
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: click
  • Confirmed dismiss event is logged in the diagnostic log
[9661:775:0902/091809.657884:VERBOSE3:ad_notification_event_dismissed.cc(32)] Dismissed ad notification with uuid 7d365796-6484-4da0-ba52-66531debb5e5 and 23051588-5707-4503-b601-fbb3ee9515e9 creative instance id
[9661:775:0902/091809.658070:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 23051588-5707-4503-b601-fbb3ee9515e9
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: dismiss
  • Confirmed when an ad times-out the event is logged in the diagnostic log
[9698:775:0902/091933.868782:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid d2c984c6-2793-465a-bf50-3632a869ec9d in 120 seconds
[9698:775:0902/092133.871694:VERBOSE3:ad_notification_event_timed_out.cc(26)] Timed out ad notification with uuid d2c984c6-2793-465a-bf50-3632a869ec9d and 1bfb02ec-0d2b-4d17-9727-eabf00a77b75 creative instance id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Ads
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants