Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] webtorrent .torrent file detection security issue #11488

Closed
diracdeltas opened this issue Aug 27, 2020 · 4 comments · Fixed by brave/brave-core#6531
Closed

[Desktop] webtorrent .torrent file detection security issue #11488

diracdeltas opened this issue Aug 27, 2020 · 4 comments · Fixed by brave/brave-core#6531

Comments

@diracdeltas
Copy link
Member

https://hackerone.com/reports/963155

diracdeltas added a commit to diracdeltas/brave-core that referenced this issue Aug 28, 2020
diracdeltas added a commit to diracdeltas/brave-core that referenced this issue Aug 28, 2020
@diracdeltas diracdeltas added this to the 1.15.x - Nightly milestone Sep 1, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 15, 2020

Verification passed on


Brave | 1.15.50 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

image

Verification passed on

Brave 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Screen Shot 2020-09-22 at 4 52 41 PM

Reproduced what @GeetaSarvadnya mentioned via #11488 (comment). Also reproduced/ran into #11302.

@GeetaSarvadnya
Copy link

@feross select https://php-demo-app-shibli.cfapps.io/test-driver.php link in URL bar and enter displays save .bat file window. Is this expected?

image

@kjozwiak
Copy link
Member

kjozwiak commented Sep 22, 2020

@diracdeltas as per @GeetaSarvadnya's comment above, you can still download the POC if you paste the following URL into the omnibox rather than clicking on Save .torrent file.

* https://php-demo-app-shibli.cfapps.io/test.php

Assuming that's expected as we're not doing the check for .torrent files via the omnibox. Please let us know if we need to file a follow up to address the above.

@diracdeltas
Copy link
Member Author

@kjozwiak that's fine. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants