Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ad notifications received this month" and "Estimated earnings" are reset to 0 at midnight UTC time not local time #11618

Closed
LaurenWags opened this issue Sep 8, 2020 · 6 comments · Fixed by brave/brave-core#10104

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #9870

It looks like Ad notifications received this month on Ads panel of brave://rewards page is reset to 0 when the new month starts in UTC time, not local time.

example - if you are on the east coast of the US and it is EDT, then your timezone is UTC-4. I'd expect Ad notifications received this month to reset to 0 when the clock rolls over to 12:00am on Oct 1. However, this is occurring at 8pm on Sept 30.

Steps to Reproduce

Have a profile with ads viewed for the month. Wait for month end and watch the brave://rewards page when it would be 12:00am on the first day of the month in UTC time.

Actual result:

Ad notifications received this month changes to 0 early in my example using EDT.

Expected result:

Ad notifications received this month should change to 0 in local time (midnight) when the new month starts.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.14.75 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes, reproduces on 1.13.x
  • Can you reproduce this issue with the beta channel? yes, reproduces on 1.14.x
  • Can you reproduce this issue with the nightly channel? yes, reproduces on 1.15.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey

Note - I added OS/Android tag as this functionality is available there, however, if the fix is not applicable please remove this tag.

@LaurenWags LaurenWags added QA/Yes feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 8, 2020
@LaurenWags LaurenWags added this to New issues in Ads via automation Sep 8, 2020
@tmancey tmancey removed the QA/Yes label Oct 6, 2020
@tmancey tmancey moved this from New issues to Icebox in Ads Oct 6, 2020
@tmancey tmancey moved this from Icebox to New issues in Ads Oct 6, 2020
@tmancey tmancey added blocked needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Oct 6, 2020
@tmancey tmancey moved this from New issues to Blocked in Ads Oct 6, 2020
@tmancey tmancey moved this from Blocked to Backlog in Ads Oct 22, 2020
@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Oct 22, 2020
@tmancey tmancey changed the title [Desktop] Ad notifications received this month is reset to 0 in UTC time not local time Ad notifications received this month is reset to 0 in UTC time not local time Oct 22, 2020
@tmancey tmancey moved this from Backlog to Blocked in Ads Oct 28, 2020
@underling3311
Copy link

Has this been fixed?

@tmancey
Copy link
Collaborator

tmancey commented Nov 3, 2020

@MrWaste This has not been fixed as needs further discussion. Thanks

@tmancey tmancey moved this from Blocked to Backlog in Ads Dec 5, 2020
@tmancey tmancey removed the blocked label Feb 10, 2021
@tmancey tmancey moved this from Backlog to Icebox in Ads Feb 10, 2021
@tmancey tmancey changed the title Ad notifications received this month is reset to 0 in UTC time not local time "Ad notifications received this month" is reset to 0 at midnight UTC time not local time Mar 13, 2021
@tmancey tmancey added bug and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Mar 13, 2021
@tmancey tmancey moved this from Icebox to In progress in Ads Jun 10, 2021
@tmancey tmancey moved this from In progress to Backlog in Ads Jun 10, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 10, 2021
@tmancey
Copy link
Collaborator

tmancey commented Jun 11, 2021

@MrWaste This will be fixed as part of #16028

@tmancey tmancey self-assigned this Jun 11, 2021
@tmancey tmancey moved this from Backlog to In progress in Ads Jun 22, 2021
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Sep 2, 2021
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 2, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Sep 2, 2021

Increasing priority to P2 as user confusion and support volume spikes extremely high at turn of the month, according to community.brave.com, Twitter, and our subreddits.

@Miyayes Miyayes moved this from New Issues to On deck in Brave Rewards Sep 2, 2021
@tmancey tmancey changed the title "Ad notifications received this month" is reset to 0 at midnight UTC time not local time "Ad notifications received this month" and "Estimated earnings" are reset to 0 at midnight UTC time not local time Sep 15, 2021
@tmancey tmancey moved this from In progress to Review in Ads Sep 15, 2021
Brave Rewards automation moved this from On deck to Done Sep 16, 2021
Ads automation moved this from Review to Done Sep 16, 2021
@tmancey tmancey added this to the 1.31.x - Nightly milestone Sep 16, 2021
@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 13, 2021

Verified passed with

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)

Using my original example (being on the east coast of the US and it is EDT and my timezone is UTC-4), I confirmed that at 8pm Oct 31 the ad panel on brave://rewards did not reset. I then advanced the computer clock to 12am Nov 1 and confirmed that the ad panel reset at this time.

8pm Oct 31 12am Nov 1 12am Nov 1
8pm 10 31 12am Nov1 12am Nov1-2

Verification passed on

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

IST is UTC+5.30 (IST is 5 hours 30 mins ahead of UTC). I am using my daily driver for testing, I confirmed that at 8pm Oct 31 the ad panel on brave://rewards did not reset. I then advanced the computer clock to 12am Nov 1 and confirmed that the ad panel reset at this time.

8pm Oct 31 12am Nov 1 12am Nov 1
image image image

@stephendonner
Copy link
Collaborator

Was unable to test this on my VM in Linux, due to #18221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment